From: Simon Horman <horms@kernel.org>
To: James Chapman <jchapman@katalix.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, dsahern@kernel.org,
tparkin@katalix.com, kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH net-next] l2tp: remove unneeded null check in l2tp_v2_session_get_next
Date: Tue, 3 Sep 2024 08:24:17 +0100 [thread overview]
Message-ID: <20240903072417.GN23170@kernel.org> (raw)
In-Reply-To: <20240902142953.926891-1-jchapman@katalix.com>
On Mon, Sep 02, 2024 at 03:29:53PM +0100, James Chapman wrote:
> Sessions in l2tp_v2_session_idr always have a non-null session->tunnel
> pointer since l2tp_session_register sets it before inserting the
> session into the IDR. Therefore the null check on session->tunnel in
> l2tp_v2_session_get_next is redundant and can be removed.
>
> Fixes: aa92c1cec92b ("l2tp: add tunnel/session get_next helpers")
Hi James,
As this patch doesn't appear to fix a bug I don't think a Fixes tag is
warranted. With that in mind, if you want to cite the above commit you can
just include the following text somewhere in the patch description.
commit aa92c1cec92b ("l2tp: add tunnel/session get_next helpers")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202408111407.HtON8jqa-lkp@intel.com/
> CC: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: James Chapman <jchapman@katalix.com>
> Signed-off-by: Tom Parkin <tparkin@katalix.com>
And as you posted the patch, it would be slightly more intuitive
if your SoB line came last. But I've seen conflicting advice about
the order of tags within the past weeks.
The above notwithstanding, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-09-03 7:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 14:29 [PATCH net-next] l2tp: remove unneeded null check in l2tp_v2_session_get_next James Chapman
2024-09-03 7:24 ` Simon Horman [this message]
2024-09-03 8:02 ` Dan Carpenter
2024-09-03 10:48 ` James Chapman
2024-09-03 11:37 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903072417.GN23170@kernel.org \
--to=horms@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jchapman@katalix.com \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).