From: Takamitsu Iwai <takamitz@amazon.co.jp>
To: <andrew@lunn.ch>
Cc: <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<edumazet@google.com>, <intel-wired-lan@lists.osuosl.org>,
<kuba@kernel.org>, <netdev@vger.kernel.org>, <pabeni@redhat.com>,
<przemyslaw.kitszel@intel.com>, <takamitz@amazon.co.jp>
Subject: Re: [PATCH v1 net-next] e1000e: Remove duplicated writel() in e1000_configure_tx/rx()
Date: Tue, 3 Sep 2024 19:46:42 +0900 [thread overview]
Message-ID: <20240903104642.75303-1-takamitz@amazon.co.jp> (raw)
In-Reply-To: <87af1b9e-21c3-4c22-861a-b917b5cd82c2@lunn.ch>
> Did the same sequence of read/writes happen before 0845d45e900c? Or
> did 0845d45e900c add additional writes, not just move them around?
The sequence of read/writes happened before 0845d45e900c because the similar
writel() exists in ew32() above the writel() moved by 0845d45e900c.
The commit 0845d45e900c moved writel() in e1000_clean_tx/rx_ring() to
e1000_configure_tx/rx() to avoid null pointer dereference. But since the same
writel() exists in e1000_configure_tx/rx(), we just needed to remove writel()
from e1000_clean_rx/tx_ring().
next prev parent reply other threads:[~2024-09-03 10:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 6:14 [PATCH v1 net-next] e1000e: Remove duplicated writel() in e1000_configure_tx/rx() Takamitsu Iwai
2024-09-02 16:04 ` Andrew Lunn
2024-09-03 10:46 ` Takamitsu Iwai [this message]
2024-09-03 16:49 ` Andrew Lunn
2024-09-04 5:56 ` Takamitsu Iwai
2024-09-04 6:41 ` Kohei Enju
2024-09-04 12:13 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903104642.75303-1-takamitz@amazon.co.jp \
--to=takamitz@amazon.co.jp \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).