netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <edumazet@google.com>,
	<pabeni@redhat.com>, <dsahern@kernel.org>, <gnault@redhat.com>,
	Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next 0/4] Unmask upper DSCP bits - part 3
Date: Tue, 3 Sep 2024 16:53:23 +0300	[thread overview]
Message-ID: <20240903135327.2810535-1-idosch@nvidia.com> (raw)

tl;dr - This patchset continues to unmask the upper DSCP bits in the
IPv4 flow key in preparation for allowing IPv4 FIB rules to match on
DSCP. No functional changes are expected.

The TOS field in the IPv4 flow key ('flowi4_tos') is used during FIB
lookup to match against the TOS selector in FIB rules and routes.

It is currently impossible for user space to configure FIB rules that
match on the DSCP value as the upper DSCP bits are either masked in the
various call sites that initialize the IPv4 flow key or along the path
to the FIB core.

In preparation for adding a DSCP selector to IPv4 and IPv6 FIB rules, we
need to make sure the entire DSCP value is present in the IPv4 flow key.
This patchset continues to unmask the upper DSCP bits, but this time in
the output route path, specifically in the callers of
ip_route_output_ports().

The next patchset (last) will handle the callers of
ip_route_output_key(). Split from this patchset to avoid going over the
15 patches limit.

No functional changes are expected as commit 1fa3314c14c6 ("ipv4:
Centralize TOS matching") moved the masking of the upper DSCP bits to
the core where 'flowi4_tos' is matched against the TOS selector.

Ido Schimmel (4):
  ipv4: Unmask upper DSCP bits in __ip_queue_xmit()
  ipv4: ipmr: Unmask upper DSCP bits in ipmr_queue_xmit()
  ip6_tunnel: Unmask upper DSCP bits in ip4ip6_err()
  ipv6: sit: Unmask upper DSCP bits in ipip6_tunnel_bind_dev()

 net/ipv4/ip_output.c  | 2 +-
 net/ipv4/ipmr.c       | 4 ++--
 net/ipv6/ip6_tunnel.c | 7 +++++--
 net/ipv6/sit.c        | 2 +-
 4 files changed, 9 insertions(+), 6 deletions(-)

-- 
2.46.0


             reply	other threads:[~2024-09-03 13:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 13:53 Ido Schimmel [this message]
2024-09-03 13:53 ` [PATCH net-next 1/4] ipv4: Unmask upper DSCP bits in __ip_queue_xmit() Ido Schimmel
2024-09-03 15:52   ` Guillaume Nault
2024-09-03 13:53 ` [PATCH net-next 2/4] ipv4: ipmr: Unmask upper DSCP bits in ipmr_queue_xmit() Ido Schimmel
2024-09-03 15:54   ` Guillaume Nault
2024-09-03 13:53 ` [PATCH net-next 3/4] ip6_tunnel: Unmask upper DSCP bits in ip4ip6_err() Ido Schimmel
2024-09-03 15:59   ` Guillaume Nault
2024-09-03 13:53 ` [PATCH net-next 4/4] ipv6: sit: Unmask upper DSCP bits in ipip6_tunnel_bind_dev() Ido Schimmel
2024-09-03 16:02   ` Guillaume Nault
2024-09-03 14:45 ` [PATCH net-next 0/4] Unmask upper DSCP bits - part 3 David Ahern
2024-09-05  0:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240903135327.2810535-1-idosch@nvidia.com \
    --to=idosch@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=gnault@redhat.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).