* [PATCH] selftests: net: convert comma to semicolon
@ 2024-09-03 7:45 Chen Ni
2024-09-03 16:19 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2024-09-03 7:45 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, shuah
Cc: netdev, linux-kselftest, linux-kernel, Chen Ni
Replace a comma between expression statements by a semicolon.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
tools/testing/selftests/net/psock_fanout.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/psock_fanout.c b/tools/testing/selftests/net/psock_fanout.c
index 1a736f700be4..4f31e92ebd96 100644
--- a/tools/testing/selftests/net/psock_fanout.c
+++ b/tools/testing/selftests/net/psock_fanout.c
@@ -165,9 +165,9 @@ static void sock_fanout_set_ebpf(int fd)
attr.insns = (unsigned long) prog;
attr.insn_cnt = ARRAY_SIZE(prog);
attr.license = (unsigned long) "GPL";
- attr.log_buf = (unsigned long) log_buf,
- attr.log_size = sizeof(log_buf),
- attr.log_level = 1,
+ attr.log_buf = (unsigned long) log_buf;
+ attr.log_size = sizeof(log_buf);
+ attr.log_level = 1;
pfd = syscall(__NR_bpf, BPF_PROG_LOAD, &attr, sizeof(attr));
if (pfd < 0) {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: net: convert comma to semicolon
2024-09-03 7:45 [PATCH] selftests: net: convert comma to semicolon Chen Ni
@ 2024-09-03 16:19 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2024-09-03 16:19 UTC (permalink / raw)
To: Chen Ni
Cc: davem, edumazet, kuba, pabeni, shuah, netdev, linux-kselftest,
linux-kernel
On Tue, Sep 03, 2024 at 03:45:19PM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
As mentioned at [1] I think it would be nice if the patch description
was a bit more descriptive.
[1] https://lore.kernel.org/all/20240903152125.GA4792@kernel.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-03 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-03 7:45 [PATCH] selftests: net: convert comma to semicolon Chen Ni
2024-09-03 16:19 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).