From: Jakub Kicinski <kuba@kernel.org>
To: Guillaume Nault <gnault@redhat.com>
Cc: David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org,
Martin Varghese <martin.varghese@nokia.com>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net] bareudp: Fix device stats updates.
Date: Wed, 4 Sep 2024 07:57:32 -0700 [thread overview]
Message-ID: <20240904075732.697226a0@kernel.org> (raw)
In-Reply-To: <ZthSuJWkCn+7na9k@debian>
On Wed, 4 Sep 2024 14:29:44 +0200 Guillaume Nault wrote:
> > The driver already uses struct pcpu_sw_netstats, would it make sense to
> > bump it up to struct pcpu_dstats and have per CPU rx drops as well?
>
> Long term, I was considering moving bareudp to use dev->tstats for
> packets/bytes and dev->core_stats for drops. It looks like dev->dstats
> is only used for VRF, so I didn't consider it.
Right, d stands for dummy so I guess they also were used by dummy
at some stage? Mostly I think it's a matter of the other stats being
less recent.
> Should we favour dev->dstats for tunnels instead of combining ->tstats
> and ->core_stats? (vxlan uses the later for example).
Seems reasonable to me. Not important enough to convert existing
drivers, maybe, unless someone sees contention. But in new code,
or if we're touching the relevant lines I reckon we should consider it?
No strong feelings tho, LMK if you want to send v2 or keep this patch
as is.
next prev parent reply other threads:[~2024-09-04 14:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 15:31 [PATCH net] bareudp: Fix device stats updates Guillaume Nault
2024-08-31 14:56 ` Willem de Bruijn
2024-09-03 18:34 ` Jakub Kicinski
2024-09-04 12:29 ` Guillaume Nault
2024-09-04 14:57 ` Jakub Kicinski [this message]
2024-09-04 17:54 ` Guillaume Nault
2024-09-04 21:48 ` Jakub Kicinski
2024-09-06 10:42 ` Guillaume Nault
2024-09-06 12:47 ` Eric Dumazet
2024-09-10 10:28 ` Guillaume Nault
2024-09-05 1:50 ` David Ahern
2024-09-06 10:30 ` Guillaume Nault
2024-09-04 22:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904075732.697226a0@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=martin.varghese@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).