From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, claudiu.manoil@nxp.com,
alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com,
andrew@lunn.ch, f.fainelli@gmail.com, michael@walle.cc,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: felix: ignore pending status of TAS module when it's disabled
Date: Wed, 4 Sep 2024 13:12:13 +0300 [thread overview]
Message-ID: <20240904101213.oqdf3brqlzzmgln5@skbuf> (raw)
In-Reply-To: <20240904102722.45427-1-xiaoliang.yang_1@nxp.com>
Hi Xiaoliang,
On Wed, Sep 04, 2024 at 06:27:22PM +0800, Xiaoliang Yang wrote:
> The TAS module could not be configured when it's running in pending
> status. We need disable the module and configure it again. However, the
> pending status is not cleared after the module disabled. So we don't
> need to check the pending status if TAS module is disabled.
>
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> ---
Does this fix a functional, user-visible problem? If so, which problem is that?
Could you describe it in the commit message? And maybe add a Fixes: tag
to the patch where the problem was first visible?
next prev parent reply other threads:[~2024-09-04 10:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 10:27 [PATCH net] net: dsa: felix: ignore pending status of TAS module when it's disabled Xiaoliang Yang
2024-09-04 10:12 ` Vladimir Oltean [this message]
2024-09-06 9:14 ` Xiaoliang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904101213.oqdf3brqlzzmgln5@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox