From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net,
Pantelis Antoniou <pantelis.antoniou@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
Herve Codina <herve.codina@bootlin.com>,
Simon Horman <horms@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH net-next v2 4/7] net: ethernet: fs_enet: drop unused phy_info and mii_if_info
Date: Wed, 4 Sep 2024 10:52:13 +0200 [thread overview]
Message-ID: <20240904105213.0756629d@fedora.home> (raw)
In-Reply-To: <a6eeb9e1-09f0-47a4-bf78-d59037398078@lunn.ch>
Hi Andrew,
On Fri, 30 Aug 2024 23:07:56 +0200
Andrew Lunn <andrew@lunn.ch> wrote:
> On Thu, Aug 29, 2024 at 06:15:27PM +0200, Maxime Chevallier wrote:
> > There's no user of the struct phy_info, the 'phy' field and the
> > mii_if_info in the fs_enet driver, probably dating back when phylib
> > wasn't as widely used. Drop these from the driver code.
>
> There might be an include of linux/mii.h you can also drop?
Oh nice catch ! They are indeed no longer useful, I'll add that in V3.
Thanks,
Maxime
next prev parent reply other threads:[~2024-09-04 8:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 16:15 [PATCH net-next v2 0/7] net: ethernet: fs_enet: Cleanup and phylink conversion Maxime Chevallier
2024-08-29 16:15 ` [PATCH net-next v2 1/7] net: ethernet: fs_enet: convert to SPDX Maxime Chevallier
2024-08-30 20:56 ` Andrew Lunn
2024-08-29 16:15 ` [PATCH net-next v2 2/7] net: ethernet: fs_enet: cosmetic cleanups Maxime Chevallier
2024-08-30 21:00 ` Andrew Lunn
2024-08-29 16:15 ` [PATCH net-next v2 3/7] net: ethernet: fs_enet: drop the .adjust_link custom fs_ops Maxime Chevallier
2024-08-30 21:06 ` Andrew Lunn
2024-09-04 8:27 ` Maxime Chevallier
2024-09-04 12:36 ` Andrew Lunn
2024-09-04 15:50 ` Maxime Chevallier
2024-08-29 16:15 ` [PATCH net-next v2 4/7] net: ethernet: fs_enet: drop unused phy_info and mii_if_info Maxime Chevallier
2024-08-30 21:06 ` Andrew Lunn
2024-08-30 21:07 ` Andrew Lunn
2024-09-04 8:52 ` Maxime Chevallier [this message]
2024-08-29 16:15 ` [PATCH net-next v2 5/7] net: ethernet: fs_enet: fcc: use macros for speed and duplex values Maxime Chevallier
2024-08-30 21:08 ` Andrew Lunn
2024-08-29 16:15 ` [PATCH net-next v2 6/7] net: ethernet: fs_enet: simplify clock handling with devm accessors Maxime Chevallier
2024-08-30 21:09 ` Andrew Lunn
2024-08-29 16:15 ` [PATCH net-next v2 7/7] net: ethernet: fs_enet: phylink conversion Maxime Chevallier
2024-09-03 1:55 ` Jakub Kicinski
2024-09-04 10:49 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904105213.0756629d@fedora.home \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pantelis.antoniou@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).