From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A16C919B3C3; Wed, 4 Sep 2024 08:52:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725439939; cv=none; b=hlov4bDwoKOjqA94FInou2IZA12I4HyXwJzx6/uyXpQl9RGswaBSAoPeHUuiKP6Jyloyc2F/ECgc8MqhT4LZRZEs4N0v8Ys/lix+OEiGUG1iLz5iYzqtx+xVn8gvOaangcCfLmCvIaWOLG+nUxd2epqg1D76CgTQW6pAbI8JXa0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725439939; c=relaxed/simple; bh=HSJBwW+MHAYy1AdbMrHJblicKcjmvt8EgdQB+6w4QF4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pdrJT6Z8P5VrnPcuaiC3D0Jn8RLfagwx5+xfSiXWZ0/YZbiYf0f0xFYfYHTeF3T/53EScVnWFBG4vEdvIEdhE8wzwnDsg2UOM9+FNihjDlZWm9oLPpwvbeUwHlfCidxE6DiQWnijr0FBgjGRFBCJU8DTyybNatN1a43KVZOJ+NE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=o6jghW40; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="o6jghW40" Received: by mail.gandi.net (Postfix) with ESMTPSA id DAC3824000C; Wed, 4 Sep 2024 08:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1725439936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/gQVLtPniH2vSqBzxSwNJZS10K7mVOFLUlzmTaph06o=; b=o6jghW40e7NxWe+r/5ufjYWB0EyArQLTsDLkEjimsQpoxMs7ZrHLu2tFrBzlH3SE/vLF5d tnDBS5epwhzwX/E2hq6oGuPYi5ZrvXoOF3HkfohVPZKOLSpN4jrJZQCkhn2j7cxvr/52DP rBBNAdSOAeLIsIA1olc2I2fA1v4JneJ/5dTdAihY2nhHFzxKQFIY8C0+KhDkAh7KhkcG9m +yMrMTEvQlOzUaSqUoaNRrSuhc6bZEAqNCVa33UHaDQC7gtHk7VhqiFItyi7N08LRsCIIY Dma7a2qgvvlKh6X1vMiRzFQY/6FdSpHzrIgtHF3xJJrHmPIof1nXO5B1T+oPGQ== Date: Wed, 4 Sep 2024 10:52:13 +0200 From: Maxime Chevallier To: Andrew Lunn Cc: davem@davemloft.net, Pantelis Antoniou , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , Christophe Leroy , Florian Fainelli , Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Herve Codina , Simon Horman , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH net-next v2 4/7] net: ethernet: fs_enet: drop unused phy_info and mii_if_info Message-ID: <20240904105213.0756629d@fedora.home> In-Reply-To: References: <20240829161531.610874-1-maxime.chevallier@bootlin.com> <20240829161531.610874-5-maxime.chevallier@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: maxime.chevallier@bootlin.com Hi Andrew, On Fri, 30 Aug 2024 23:07:56 +0200 Andrew Lunn wrote: > On Thu, Aug 29, 2024 at 06:15:27PM +0200, Maxime Chevallier wrote: > > There's no user of the struct phy_info, the 'phy' field and the > > mii_if_info in the fs_enet driver, probably dating back when phylib > > wasn't as widely used. Drop these from the driver code. > > There might be an include of linux/mii.h you can also drop? Oh nice catch ! They are indeed no longer useful, I'll add that in V3. Thanks, Maxime