[PATCH v1 0/7] Use functionality of irq_get_trigger_type()

[PATCH v1 0/7] Use functionality of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Inspired by: https://lore.kernel.org/linux-iio/20240901135950.797396-1-jic23@kernel.org/

Vasileios Amoiridis (7):
  drm/i2c: tda998x: Make use of irq_get_trigger_type()
  net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()
  net: dsa: realtek: rtl8366rb: Make use of irq_get_trigger_type()
  net: smc91x: Make use of irq_get_trigger_type()
  wifi: brcmfmac: of: Make use of irq_get_trigger_type()
  wifi: wlcore: sdio: Make use of irq_get_trigger_type()
  of/irq: Make use of irq_get_trigger_type()

 drivers/gpu/drm/i2c/tda998x_drv.c                     | 3 +--
 drivers/net/dsa/realtek/rtl8365mb.c                   | 2 +-
 drivers/net/dsa/realtek/rtl8366rb.c                   | 2 +-
 drivers/net/ethernet/smsc/smc91x.c                    | 2 +-
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 2 +-
 drivers/net/wireless/ti/wlcore/sdio.c                 | 5 ++---
 drivers/of/irq.c                                      | 2 +-
 7 files changed, 8 insertions(+), 10 deletions(-)


base-commit: ecc768a84f0b8e631986f9ade3118fa37852fef0
-- 
2.25.1

[PATCH v1 1/7] drm/i2c: tda998x: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 2160f05bbd16..8dfcebec800e 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1911,8 +1911,7 @@ static int tda998x_create(struct device *dev)
 		/* init read EDID waitqueue and HDP work */
 		init_waitqueue_head(&priv->wq_edid);
 
-		irq_flags =
-			irqd_get_trigger_type(irq_get_irq_data(client->irq));
+		irq_flags = irq_get_trigger_type(client->irq);
 
 		priv->cec_glue.irq_flags = irq_flags;
 

base-commit: ecc768a84f0b8e631986f9ade3118fa37852fef0
-- 
2.25.1

[PATCH v1 2/7] net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
index b9674f68b756..ad7044b295ec 100644
--- a/drivers/net/dsa/realtek/rtl8365mb.c
+++ b/drivers/net/dsa/realtek/rtl8365mb.c
@@ -1740,7 +1740,7 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv)
 	}
 
 	/* Configure chip interrupt signal polarity */
-	irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
+	irq_trig = irq_get_trigger_type(irq);
 	switch (irq_trig) {
 	case IRQF_TRIGGER_RISING:
 	case IRQF_TRIGGER_HIGH:
-- 
2.25.1

Re: [PATCH v1 2/7] net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()

[Alvin Šipraga]

On Tue, Sep 03, 2024 at 12:55:29AM GMT, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
>  drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>

Btw, I think this is something for net-next (not a bugfix?), so you
would normally add the appropriate prefix, i.e. [PATCH net-next ...],
when sending to netdev.

> 
> diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
> index b9674f68b756..ad7044b295ec 100644
> --- a/drivers/net/dsa/realtek/rtl8365mb.c
> +++ b/drivers/net/dsa/realtek/rtl8365mb.c
> @@ -1740,7 +1740,7 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv)
>  	}
>  
>  	/* Configure chip interrupt signal polarity */
> -	irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
> +	irq_trig = irq_get_trigger_type(irq);
>  	switch (irq_trig) {
>  	case IRQF_TRIGGER_RISING:
>  	case IRQF_TRIGGER_HIGH:
> -- 
> 2.25.1
>

[PATCH v1 3/7] net: dsa: realtek: rtl8366rb: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/dsa/realtek/rtl8366rb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/realtek/rtl8366rb.c b/drivers/net/dsa/realtek/rtl8366rb.c
index 9e821b42e5f3..e49cfdfb85cb 100644
--- a/drivers/net/dsa/realtek/rtl8366rb.c
+++ b/drivers/net/dsa/realtek/rtl8366rb.c
@@ -599,7 +599,7 @@ static int rtl8366rb_setup_cascaded_irq(struct realtek_priv *priv)
 	}
 
 	/* Fetch IRQ edge information from the descriptor */
-	irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
+	irq_trig = irq_get_trigger_type(irq);
 	switch (irq_trig) {
 	case IRQF_TRIGGER_RISING:
 	case IRQF_TRIGGER_HIGH:
-- 
2.25.1

Re: [PATCH v1 3/7] net: dsa: realtek: rtl8366rb: Make use of irq_get_trigger_type()

[Alvin Šipraga]

On Tue, Sep 03, 2024 at 12:55:30AM GMT, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
>  drivers/net/dsa/realtek/rtl8366rb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>

> 
> diff --git a/drivers/net/dsa/realtek/rtl8366rb.c b/drivers/net/dsa/realtek/rtl8366rb.c
> index 9e821b42e5f3..e49cfdfb85cb 100644
> --- a/drivers/net/dsa/realtek/rtl8366rb.c
> +++ b/drivers/net/dsa/realtek/rtl8366rb.c
> @@ -599,7 +599,7 @@ static int rtl8366rb_setup_cascaded_irq(struct realtek_priv *priv)
>  	}
>  
>  	/* Fetch IRQ edge information from the descriptor */
> -	irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
> +	irq_trig = irq_get_trigger_type(irq);
>  	switch (irq_trig) {
>  	case IRQF_TRIGGER_RISING:
>  	case IRQF_TRIGGER_HIGH:
> -- 
> 2.25.1
>

Re: [PATCH v1 3/7] net: dsa: realtek: rtl8366rb: Make use of irq_get_trigger_type()

[Linus Walleij]

On Tue, Sep 3, 2024 at 12:55 AM Vasileios Amoiridis
<vassilisamir@gmail.com> wrote:

> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

[PATCH v1 4/7] net: smc91x: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/ethernet/smsc/smc91x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 907498848028..a5e23e2da90f 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -2355,7 +2355,7 @@ static int smc_drv_probe(struct platform_device *pdev)
 	 * the resource supplies a trigger, override the irqflags with
 	 * the trigger flags from the resource.
 	 */
-	irq_resflags = irqd_get_trigger_type(irq_get_irq_data(ndev->irq));
+	irq_resflags = irq_get_trigger_type(ndev->irq);
 	if (irq_flags == -1 || irq_resflags & IRQF_TRIGGER_MASK)
 		irq_flags = irq_resflags & IRQF_TRIGGER_MASK;
 
-- 
2.25.1

[PATCH v1 5/7] wifi: brcmfmac: of: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type().

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
index fe4f65756105..e2611f164fa8 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
@@ -138,7 +138,7 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
 		brcmf_err("interrupt could not be mapped\n");
 		return;
 	}
-	irqf = irqd_get_trigger_type(irq_get_irq_data(irq));
+	irqf = irq_get_trigger_type(irq);
 
 	sdio->oob_irq_supported = true;
 	sdio->oob_irq_nr = irq;
-- 
2.25.1

Re: [PATCH v1 5/7] wifi: brcmfmac: of: Make use of irq_get_trigger_type()

[Kalle Valo]

Vasileios Amoiridis <vassilisamir@gmail.com> wrote:

> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type().
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>

wireless patches go via wireless-next, please submit patches 5-6
separately.

2 patches set to Changes Requested.

13787792 [v1,5/7] wifi: brcmfmac: of: Make use of irq_get_trigger_type()
13787793 [v1,6/7] wifi: wlcore: sdio: Make use of irq_get_trigger_type()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240902225534.130383-6-vassilisamir@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
https://docs.kernel.org/process/submitting-patches.html

[PATCH v1 6/7] wifi: wlcore: sdio: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/wireless/ti/wlcore/sdio.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
index 92fb5b8dcdae..9e1b644beba9 100644
--- a/drivers/net/wireless/ti/wlcore/sdio.c
+++ b/drivers/net/wireless/ti/wlcore/sdio.c
@@ -324,15 +324,13 @@ static int wl1271_probe(struct sdio_func *func,
 	memset(res, 0x00, sizeof(res));
 
 	res[0].start = irq;
-	res[0].flags = IORESOURCE_IRQ |
-		       irqd_get_trigger_type(irq_get_irq_data(irq));
+	res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
 	res[0].name = "irq";
 
 
 	if (wakeirq > 0) {
 		res[1].start = wakeirq;
-		res[1].flags = IORESOURCE_IRQ |
-			       irqd_get_trigger_type(irq_get_irq_data(wakeirq));
+		res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
 		res[1].name = "wakeirq";
 		num_irqs = 2;
 	} else {
-- 
2.25.1

Re: [PATCH v1 6/7] wifi: wlcore: sdio: Make use of irq_get_trigger_type()

[Andy Shevchenko]

On Tue, Sep 03, 2024 at 12:55:33AM +0200, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).

...

>  	memset(res, 0x00, sizeof(res));
>  
>  	res[0].start = irq;
> -	res[0].flags = IORESOURCE_IRQ |
> -		       irqd_get_trigger_type(irq_get_irq_data(irq));
> +	res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
>  	res[0].name = "irq";


>  	if (wakeirq > 0) {
>  		res[1].start = wakeirq;
> -		res[1].flags = IORESOURCE_IRQ |
> -			       irqd_get_trigger_type(irq_get_irq_data(wakeirq));
> +		res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
>  		res[1].name = "wakeirq";
>  		num_irqs = 2;

Since you are touching a lot here, consider also using macros from ioport.h,
i.e. DEFINE_RES_IRQ_NAMED().

This will become something like

	res[0] = DEFINE_RES_IRQ_NAMED(irq, "irq");
	res[0].flags |= irq_get_trigger_type(irq);

	if (wakeirq > 0) {
		res[1] = DEFINE_RES_IRQ_NAMED(wakeirq, "wakeirq");
		res[1].flags |= irq_get_trigger_type(wakeirq);

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 6/7] wifi: wlcore: sdio: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

On Tue, Sep 03, 2024 at 05:45:48PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 03, 2024 at 12:55:33AM +0200, Vasileios Amoiridis wrote:
> > Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> > simple irq_get_trigger_type(irq).
> 
> ...
> 
> >  	memset(res, 0x00, sizeof(res));
> >  
> >  	res[0].start = irq;
> > -	res[0].flags = IORESOURCE_IRQ |
> > -		       irqd_get_trigger_type(irq_get_irq_data(irq));
> > +	res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
> >  	res[0].name = "irq";
> 
> 
> >  	if (wakeirq > 0) {
> >  		res[1].start = wakeirq;
> > -		res[1].flags = IORESOURCE_IRQ |
> > -			       irqd_get_trigger_type(irq_get_irq_data(wakeirq));
> > +		res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
> >  		res[1].name = "wakeirq";
> >  		num_irqs = 2;
> 
> Since you are touching a lot here, consider also using macros from ioport.h,
> i.e. DEFINE_RES_IRQ_NAMED().
> 
> This will become something like
> 
> 	res[0] = DEFINE_RES_IRQ_NAMED(irq, "irq");
> 	res[0].flags |= irq_get_trigger_type(irq);
> 
> 	if (wakeirq > 0) {
> 		res[1] = DEFINE_RES_IRQ_NAMED(wakeirq, "wakeirq");
> 		res[1].flags |= irq_get_trigger_type(wakeirq);
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

Hi Andy,

Thank you very much for reviewing this, I will check this out
and apply the proposed changes to this and the next one.

Cheers,
Vasilis

[PATCH v1 7/7] of/irq: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/of/irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 36351ad6115e..5d27b20634d3 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -430,7 +430,7 @@ int of_irq_to_resource(struct device_node *dev, int index, struct resource *r)
 					      &name);
 
 		r->start = r->end = irq;
-		r->flags = IORESOURCE_IRQ | irqd_get_trigger_type(irq_get_irq_data(irq));
+		r->flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
 		r->name = name ? name : of_node_full_name(dev);
 	}
 
-- 
2.25.1

Re: [PATCH v1 7/7] of/irq: Make use of irq_get_trigger_type()

[Krzysztof Kozlowski]

On Tue, Sep 03, 2024 at 12:55:34AM +0200, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
>  drivers/of/irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v1 7/7] of/irq: Make use of irq_get_trigger_type()

[Rob Herring (Arm)]

On Tue, 03 Sep 2024 00:55:34 +0200, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
>  drivers/of/irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!

Re: [PATCH v1 7/7] of/irq: Make use of irq_get_trigger_type()

[Andy Shevchenko]

On Tue, Sep 03, 2024 at 09:39:43AM -0500, Rob Herring (Arm) wrote:
> On Tue, 03 Sep 2024 00:55:34 +0200, Vasileios Amoiridis wrote:

...

> Applied, thanks!

It was fast :-)

Vasileios, consider my previous comment as a material for followup,
if Rob likes the idea.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 7/7] of/irq: Make use of irq_get_trigger_type()

[Rob Herring]

On Tue, Sep 3, 2024 at 9:59 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Sep 03, 2024 at 09:39:43AM -0500, Rob Herring (Arm) wrote:
> > On Tue, 03 Sep 2024 00:55:34 +0200, Vasileios Amoiridis wrote:
>
> ...
>
> > Applied, thanks!
>
> It was fast :-)

You're right. I didn't really look at that and was catching up from holidays.

> Vasileios, consider my previous comment as a material for followup,
> if Rob likes the idea.

Yes. I've dropped the patch for now.

Rob

Re: [PATCH v1 7/7] of/irq: Make use of irq_get_trigger_type()

[Andy Shevchenko]

On Tue, Sep 03, 2024 at 12:55:34AM +0200, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).

...

>  		r->start = r->end = irq;
> -		r->flags = IORESOURCE_IRQ | irqd_get_trigger_type(irq_get_irq_data(irq));
> +		r->flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
>  		r->name = name ? name : of_node_full_name(dev);

As per previous patch this can be utilised to

		*r = DEFINE_RES_IRQ_NAMED(irq, name ?: of_node_full_name(dev));
		r->flags |= irq_get_trigger_type(irq);

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 0/7] Use functionality of irq_get_trigger_type()

[Andrew Lunn]

On Tue, Sep 03, 2024 at 12:55:27AM +0200, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Inspired by: https://lore.kernel.org/linux-iio/20240901135950.797396-1-jic23@kernel.org/
> 
> Vasileios Amoiridis (7):
>   drm/i2c: tda998x: Make use of irq_get_trigger_type()
>   net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()
>   net: dsa: realtek: rtl8366rb: Make use of irq_get_trigger_type()
>   net: smc91x: Make use of irq_get_trigger_type()
>   wifi: brcmfmac: of: Make use of irq_get_trigger_type()
>   wifi: wlcore: sdio: Make use of irq_get_trigger_type()
>   of/irq: Make use of irq_get_trigger_type()

Please spit these by subsystems.

For networking, you should read:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

	Andrew