Re: [PATCH net-next] virtio_net: Fix napi_skb_cache_put warning

Breno Leitao
2024-09-05T09:03:29Z

Hello Leonardo, good to see you here,

On Tue, Sep 03, 2024 at 01:28:50PM -0300, Leonardo Bras wrote:
> Please help me check if the following is correct:
> ###
> Any tree which includes df133f3f9625 ("virtio_net: bulk free tx skbs")
> should also include your patch, since it fixes stuff in there.
>
> The fact that the warning was only made visible in
> bdacf3e34945 ("net: Use nested-BH locking for napi_alloc_cache.")
> does not change the fact that it was already present before.
>
> Also, having bdacf3e34945 is not necessary for the backport, since
> it only made the bug visible.
> ###
>
> Are above statements right?

That is exactly correct.

The bug was introduced by df133f3f9625 ("virtio_net: bulk free tx
skbs"), but it was not visible until bdacf3e34945 ("net: Use nested-BH
locking for napi_alloc_cache.") landed.

You don't need bdacf3e34945 ("net: Use nested-BH locking for
napi_alloc_cache.") patch backported if you don't want to.

I hope it helps,
--breno