From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: edward.cree@amd.com, linux-net-drivers@amd.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org,
Alexander Lobakin <aleksander.lobakin@intel.com>
Subject: Re: [PATCH net-next 2/6] sfc: implement basic per-queue stats
Date: Thu, 5 Sep 2024 07:56:00 -0700 [thread overview]
Message-ID: <20240905075600.2b0d0bca@kernel.org> (raw)
In-Reply-To: <f7da4b25-234b-8393-66c8-6adb66ebaaf8@gmail.com>
On Thu, 5 Sep 2024 11:57:59 +0100 Edward Cree wrote:
> On 29/08/2024 01:41, Jakub Kicinski wrote:
> > IOW let's not count dedicated XDP queues here at all, if we can.
>
> But they should still go in base_stats, like other not-core
> queues, right?
Yeah, I think so. I'm not 100% confident, but I think it makes sense
for tx-packets / tx-bytes to be inclusive of all more granular counters
(IOW even if we report xdp-tx-packets, the main tx-packets should also
count those frames).
next prev parent reply other threads:[~2024-09-05 14:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 13:45 [PATCH net-next 0/6] sfc: per-queue stats edward.cree
2024-08-28 13:45 ` [PATCH net-next 1/6] sfc: remove obsolete counters from struct efx_channel edward.cree
2024-08-28 22:17 ` Jacob Keller
2024-08-28 13:45 ` [PATCH net-next 2/6] sfc: implement basic per-queue stats edward.cree
2024-08-28 22:20 ` Jacob Keller
2024-08-29 0:44 ` Jakub Kicinski
2024-08-29 0:41 ` Jakub Kicinski
2024-08-29 12:03 ` Alexander Lobakin
2024-09-05 10:57 ` Edward Cree
2024-09-05 14:56 ` Jakub Kicinski [this message]
2024-08-28 13:45 ` [PATCH net-next 3/6] sfc: add n_rx_overlength to ethtool stats edward.cree
2024-08-28 22:22 ` Jacob Keller
2024-08-29 0:47 ` Jakub Kicinski
2024-09-05 10:50 ` Edward Cree
2024-08-28 13:45 ` [PATCH net-next 4/6] sfc: implement per-queue rx drop and overrun stats edward.cree
2024-08-28 22:24 ` Jacob Keller
2024-08-28 13:45 ` [PATCH net-next 5/6] sfc: implement per-queue TSO (hw_gso) stats edward.cree
2024-08-28 22:25 ` Jacob Keller
2024-08-28 13:45 ` [PATCH net-next 6/6] sfc: add per-queue RX and TX bytes stats edward.cree
2024-08-28 22:25 ` Jacob Keller
2024-08-29 0:49 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905075600.2b0d0bca@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).