From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, ncardwell@google.com, shuah@kernel.org,
linux-kselftest@vger.kernel.org, fw@strlen.de,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next 2/2] selftests/net: integrate packetdrill with ksft
Date: Thu, 5 Sep 2024 14:31:28 -0700 [thread overview]
Message-ID: <20240905143128.0dde754f@kernel.org> (raw)
In-Reply-To: <20240905031233.1528830-3-willemdebruijn.kernel@gmail.com>
On Wed, 4 Sep 2024 23:07:03 -0400 Willem de Bruijn wrote:
> +++ b/tools/testing/selftests/net/packetdrill/config
> @@ -0,0 +1 @@
> +CONFIG_TCP_MD5SIG=y
Looks like this is not enough:
# 1..2
# open tun device: No such file or directory
# not ok 1 ipv4
# open tun device: No such file or directory
https://netdev-3.bots.linux.dev/vmksft-packetdrill/results/759141/1-tcp-inq-client-pkt/stdout
Resulting config in the build:
# CONFIG_TUN is not set
https://netdev-3.bots.linux.dev/vmksft-packetdrill/results/759141/config
Keep in mind the "Important" note here:
https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style#how-to-build
I recommend using a fresh tree or mrproper for testing vng configs.
Feel free to post v2 without the 24h wait, it's a bit tricky to handle
new targets in CI, sooner we merge this the less manual work for me..
next prev parent reply other threads:[~2024-09-05 21:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 3:07 [PATCH net-next 0/2] selftests/net: add packetdrill Willem de Bruijn
2024-09-05 3:07 ` [PATCH net-next 1/2] selftests: support interpreted scripts with ksft_runner.sh Willem de Bruijn
2024-09-05 3:07 ` [PATCH net-next 2/2] selftests/net: integrate packetdrill with ksft Willem de Bruijn
2024-09-05 21:31 ` Jakub Kicinski [this message]
2024-09-05 23:24 ` Willem de Bruijn
2024-09-06 0:20 ` Willem de Bruijn
2024-09-06 1:31 ` Willem de Bruijn
2024-09-06 1:42 ` Jakub Kicinski
2024-09-06 2:45 ` Willem de Bruijn
2024-09-06 7:24 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905143128.0dde754f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=linux-kselftest@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).