From: Jakub Kicinski <kuba@kernel.org>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ftgmac100: Enable TX interrupt to avoid TX timeout
Date: Thu, 5 Sep 2024 14:47:12 -0700 [thread overview]
Message-ID: <20240905144712.6492ca9b@kernel.org> (raw)
In-Reply-To: <20240904103116.4022152-1-jacky_chou@aspeedtech.com>
On Wed, 4 Sep 2024 18:31:16 +0800 Jacky Chou wrote:
> Currently, the driver only enables RX interrupt to handle RX
> packets and TX resources. Sometimes there is not RX traffic,
> so the TX resource needs to wait for RX interrupt to free.
> This situation will toggle the TX timeout watchdog when the MAC
> TX ring has no more resources to transmit packets.
> Therefore, enable TX interrupt to release TX resources at any time.
Please answer Andrew's question (preferably send a v2 with the answer
as part of the commit message). Add a fixes tag, I think this is where
the bug was added?
Fixes: 10cbd6407609 ("ftgmac100: Rework NAPI & interrupts handling")
And when you send v2, please make sure to CC the author (Benjamin).
--
pw-bot: cr
prev parent reply other threads:[~2024-09-05 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 10:31 [PATCH] net: ftgmac100: Enable TX interrupt to avoid TX timeout Jacky Chou
2024-09-05 20:50 ` Andrew Lunn
[not found] ` <SEYPR06MB51345FBC0146F1517B36584B9D9E2@SEYPR06MB5134.apcprd06.prod.outlook.com>
2024-09-06 11:48 ` 回覆: " Andrew Lunn
2024-09-05 21:47 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905144712.6492ca9b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacky_chou@aspeedtech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).