From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF70513FFC; Fri, 6 Sep 2024 00:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725582032; cv=none; b=gTAf7bOtir9N8tWQCJ9spuW2QFwO+nyHe3+qUqmlhRXm604EgwwYyHdGI+8Q6mUfiiRu6oW0aJ2ubYZyKirulMuXpS612p0mstEbfLNDSX7W482zvacEAaeahHk20DLUPp0CMqLTQ3LNwoOCmcHaDcqLQntGBvEI1Mxtc9WNkXg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725582032; c=relaxed/simple; bh=4V8o7Ima5HsTiALZdyULmSsGXq6cAPqQaG4Zo+80WXE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H8aP6MINEbAErjWGyVdUQM+LA7QJdO6AmF0PL1nSC8udLxVdPobAMct8eYhej6bBc22eUIFf/Y7Eo6YDFkoC4TSe8PAbA7txZXub17z0fHMHxa17ZD/RLW2wLC/99DgKlcRgKyTECYnHiMaaX0zOgFNFi3LwYRHDIa/7AmN4rM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A6HGSkX4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A6HGSkX4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D87D2C4CEC3; Fri, 6 Sep 2024 00:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725582031; bh=4V8o7Ima5HsTiALZdyULmSsGXq6cAPqQaG4Zo+80WXE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=A6HGSkX4KQQoEijgosNXs2DSkeWoJaozDuYE7kgCzE/dzlneEBElxw3Az9zZ+P1Fh YW6ChfTAUGhMlq3fEQdypw9p1PHAfXdE3WGwZ1tOAnGEmxqnWWICfrqJfc1scCYSA9 ibit0x6LAGy8nkTWTyCMkbpYb42/4WQXLIA2ixWt4Llizm+42ssMp7H4SsEsjNrs1b dz6HrcdqR/dg6pw2TuH8dkKw2kyEXStCCes+dW57UxTP4SWzK0SxnAmxV/yQSLCiDN rXgnGx7KACi5uOYJaRRWSCQoLRC4vBwev4agIZnqRD80Wj8dEa7mKOz2MnelvRYhoX 9JtaaZXYqlQmg== Date: Thu, 5 Sep 2024 17:20:29 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: Alexander Lobakin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Daniel Xu , John Fastabend , Jesper Dangaard Brouer , Martin KaFai Lau , "David S. Miller" , Eric Dumazet , Paolo Abeni , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next 0/9] bpf: cpumap: enable GRO for XDP_PASS frames Message-ID: <20240905172029.5e9ca520@kernel.org> In-Reply-To: References: <20240830162508.1009458-1-aleksander.lobakin@intel.com> <20240903135158.7031a3ab@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 5 Sep 2024 19:01:42 +0200 Lorenzo Bianconi wrote: > In particular, the cpumap kthread pinned on cpu 'n' can schedule the > backlog NAPI associated to cpu 'n'. However according to my understanding > it seems the backlog NAPI APIs (in process_backlog()) do not support GRO, > right? Am I missing something? I meant to use the struct directly, not to schedule it. All you need is GRO - feed it packets, flush it. But maybe you can avoid the netdev allocation and patch 3 in other ways. Using backlog NAPI was just the first thing that came to mind.