From: Jakub Kicinski <kuba@kernel.org>
To: Nelson Escobar <neescoba@cisco.com>
Cc: netdev@vger.kernel.org, satishkh@cisco.com, johndale@cisco.com
Subject: Re: [PATCH net-next v2 3/4] enic: Report per queue statistics in ethtool
Date: Thu, 5 Sep 2024 18:31:42 -0700 [thread overview]
Message-ID: <20240905183142.424c1d72@kernel.org> (raw)
In-Reply-To: <20240905010900.24152-4-neescoba@cisco.com>
On Wed, 4 Sep 2024 18:08:59 -0700 Nelson Escobar wrote:
> Make 'ethtool -S <intf>' output show per rq/wq statistics.
> +static const struct enic_stat enic_per_wq_stats[] = {
> + ENIC_PER_WQ_STAT(packets),
> + ENIC_PER_WQ_STAT(stopped),
Stats for which structured APIs exist must not be added to ethtool -S
Please filter things which exist in qstat out of ethtool
please see:
https://docs.kernel.org/next/networking/statistics.html#notes-for-driver-authors
(it talks about rtnl_link_stats because only those existed at the time).
next prev parent reply other threads:[~2024-09-06 1:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 1:08 [PATCH net-next v2 0/4] enic: Report per queue stats Nelson Escobar
2024-09-05 1:08 ` [PATCH net-next v2 1/4] enic: Use macro instead of static const variables for array sizes Nelson Escobar
2024-09-05 1:08 ` [PATCH net-next v2 2/4] enic: Collect per queue statistics Nelson Escobar
2024-09-05 1:08 ` [PATCH net-next v2 3/4] enic: Report per queue statistics in ethtool Nelson Escobar
2024-09-06 1:31 ` Jakub Kicinski [this message]
2024-09-05 1:09 ` [PATCH net-next v2 4/4] enic: Report per queue statistics in netdev qstats Nelson Escobar
2024-09-06 1:31 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905183142.424c1d72@kernel.org \
--to=kuba@kernel.org \
--cc=johndale@cisco.com \
--cc=neescoba@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=satishkh@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).