From: Martin Habets <habetsm.xilinx@gmail.com>
To: Rohit Chavan <roheetchavan@gmail.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-net-drivers@amd.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sfc: It's a small cleanup to use ERR_CAST() here.
Date: Fri, 6 Sep 2024 10:01:09 +0100 [thread overview]
Message-ID: <20240906085955.GA17975@gmail.com> (raw)
In-Reply-To: <20240906055950.729327-1-roheetchavan@gmail.com>
This was already done as
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=74ce94ac38a6
Thanks,
Martin
On Fri, Sep 06, 2024 at 11:29:50AM +0530, Rohit Chavan wrote:
> Using ERR_CAST() is more reasonable and safer, When it is necessary
> to convert the type of an error pointer and return it.
>
> Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
> ---
> drivers/net/ethernet/sfc/tc_counters.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/tc_counters.c b/drivers/net/ethernet/sfc/tc_counters.c
> index c44088424323..76d32641202b 100644
> --- a/drivers/net/ethernet/sfc/tc_counters.c
> +++ b/drivers/net/ethernet/sfc/tc_counters.c
> @@ -249,7 +249,7 @@ struct efx_tc_counter_index *efx_tc_flower_get_counter_index(
> &ctr->linkage,
> efx_tc_counter_id_ht_params);
> kfree(ctr);
> - return (void *)cnt; /* it's an ERR_PTR */
> + return ERR_CAST(cnt); /* it's an ERR_PTR */
> }
> ctr->cnt = cnt;
> refcount_set(&ctr->ref, 1);
> --
> 2.34.1
>
prev parent reply other threads:[~2024-09-06 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 5:59 [PATCH] sfc: It's a small cleanup to use ERR_CAST() here Rohit Chavan
2024-09-06 9:01 ` Martin Habets [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906085955.GA17975@gmail.com \
--to=habetsm.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roheetchavan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).