* [PATCH] sfc: It's a small cleanup to use ERR_CAST() here.
@ 2024-09-06 5:59 Rohit Chavan
2024-09-06 9:01 ` Martin Habets
0 siblings, 1 reply; 2+ messages in thread
From: Rohit Chavan @ 2024-09-06 5:59 UTC (permalink / raw)
To: Edward Cree, Martin Habets, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, linux-net-drivers,
linux-kernel
Cc: Rohit Chavan
Using ERR_CAST() is more reasonable and safer, When it is necessary
to convert the type of an error pointer and return it.
Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
---
drivers/net/ethernet/sfc/tc_counters.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/tc_counters.c b/drivers/net/ethernet/sfc/tc_counters.c
index c44088424323..76d32641202b 100644
--- a/drivers/net/ethernet/sfc/tc_counters.c
+++ b/drivers/net/ethernet/sfc/tc_counters.c
@@ -249,7 +249,7 @@ struct efx_tc_counter_index *efx_tc_flower_get_counter_index(
&ctr->linkage,
efx_tc_counter_id_ht_params);
kfree(ctr);
- return (void *)cnt; /* it's an ERR_PTR */
+ return ERR_CAST(cnt); /* it's an ERR_PTR */
}
ctr->cnt = cnt;
refcount_set(&ctr->ref, 1);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sfc: It's a small cleanup to use ERR_CAST() here.
2024-09-06 5:59 [PATCH] sfc: It's a small cleanup to use ERR_CAST() here Rohit Chavan
@ 2024-09-06 9:01 ` Martin Habets
0 siblings, 0 replies; 2+ messages in thread
From: Martin Habets @ 2024-09-06 9:01 UTC (permalink / raw)
To: Rohit Chavan
Cc: Edward Cree, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-net-drivers, linux-kernel
This was already done as
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=74ce94ac38a6
Thanks,
Martin
On Fri, Sep 06, 2024 at 11:29:50AM +0530, Rohit Chavan wrote:
> Using ERR_CAST() is more reasonable and safer, When it is necessary
> to convert the type of an error pointer and return it.
>
> Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
> ---
> drivers/net/ethernet/sfc/tc_counters.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/tc_counters.c b/drivers/net/ethernet/sfc/tc_counters.c
> index c44088424323..76d32641202b 100644
> --- a/drivers/net/ethernet/sfc/tc_counters.c
> +++ b/drivers/net/ethernet/sfc/tc_counters.c
> @@ -249,7 +249,7 @@ struct efx_tc_counter_index *efx_tc_flower_get_counter_index(
> &ctr->linkage,
> efx_tc_counter_id_ht_params);
> kfree(ctr);
> - return (void *)cnt; /* it's an ERR_PTR */
> + return ERR_CAST(cnt); /* it's an ERR_PTR */
> }
> ctr->cnt = cnt;
> refcount_set(&ctr->ref, 1);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-06 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-06 5:59 [PATCH] sfc: It's a small cleanup to use ERR_CAST() here Rohit Chavan
2024-09-06 9:01 ` Martin Habets
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).