netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net-timestamp: correct the use of SOF_TIMESTAMPING_RAW_HARDWARE
@ 2024-09-06  9:57 Jason Xing
  2024-09-06 15:26 ` Willem de Bruijn
  0 siblings, 1 reply; 3+ messages in thread
From: Jason Xing @ 2024-09-06  9:57 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, dsahern, willemdebruijn.kernel,
	shuah, willemb
  Cc: linux-kselftest, netdev, Jason Xing

From: Jason Xing <kernelxing@tencent.com>

SOF_TIMESTAMPING_RAW_HARDWARE is a report flag which passes the
timestamps generated by either SOF_TIMESTAMPING_TX_HARDWARE or
SOF_TIMESTAMPING_RX_HARDWARE to the userspace all the time.

So let us revise the doc here.

Link: Link: https://lore.kernel.org/all/66d8c21d3042a_163d93294cb@willemb.c.googlers.com.notmuch/
Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
previous version
Link: https://lore.kernel.org/all/66d9b467d02d3_18ac2129427@willemb.c.googlers.com.notmuch/
Link: https://lore.kernel.org/all/66d9c3f875b90_18de412948b@willemb.c.googlers.com.notmuch/
1. cook this as a stand-alone patch (Willem)
2. add Willem's reviewed-by tag since this patch doesn't change
3. move the reference link at the top of S-b tag
---
 Documentation/networking/timestamping.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/networking/timestamping.rst b/Documentation/networking/timestamping.rst
index 5e93cd71f99f..9c7773271393 100644
--- a/Documentation/networking/timestamping.rst
+++ b/Documentation/networking/timestamping.rst
@@ -158,7 +158,8 @@ SOF_TIMESTAMPING_SYS_HARDWARE:
 
 SOF_TIMESTAMPING_RAW_HARDWARE:
   Report hardware timestamps as generated by
-  SOF_TIMESTAMPING_TX_HARDWARE when available.
+  SOF_TIMESTAMPING_TX_HARDWARE or SOF_TIMESTAMPING_RX_HARDWARE
+  when available.
 
 
 1.3.3 Timestamp Options
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net-timestamp: correct the use of SOF_TIMESTAMPING_RAW_HARDWARE
  2024-09-06  9:57 [PATCH net-next] net-timestamp: correct the use of SOF_TIMESTAMPING_RAW_HARDWARE Jason Xing
@ 2024-09-06 15:26 ` Willem de Bruijn
  2024-09-06 16:18   ` Jason Xing
  0 siblings, 1 reply; 3+ messages in thread
From: Willem de Bruijn @ 2024-09-06 15:26 UTC (permalink / raw)
  To: Jason Xing, davem, edumazet, kuba, pabeni, dsahern,
	willemdebruijn.kernel, shuah, willemb
  Cc: linux-kselftest, netdev, Jason Xing

Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
> 
> SOF_TIMESTAMPING_RAW_HARDWARE is a report flag which passes the
> timestamps generated by either SOF_TIMESTAMPING_TX_HARDWARE or
> SOF_TIMESTAMPING_RX_HARDWARE to the userspace all the time.
> 
> So let us revise the doc here.
> 
> Link: Link: https://lore.kernel.org/all/66d8c21d3042a_163d93294cb@willemb.c.googlers.com.notmuch/

nit: duplicate keyword

> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Reviewed-by: Willem de Bruijn <willemb@google.com>

indeed

> Signed-off-by: Jason Xing <kernelxing@tencent.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net-timestamp: correct the use of SOF_TIMESTAMPING_RAW_HARDWARE
  2024-09-06 15:26 ` Willem de Bruijn
@ 2024-09-06 16:18   ` Jason Xing
  0 siblings, 0 replies; 3+ messages in thread
From: Jason Xing @ 2024-09-06 16:18 UTC (permalink / raw)
  To: Willem de Bruijn
  Cc: davem, edumazet, kuba, pabeni, dsahern, shuah, willemb,
	linux-kselftest, netdev, Jason Xing

On Fri, Sep 6, 2024 at 11:26 PM Willem de Bruijn
<willemdebruijn.kernel@gmail.com> wrote:
>
> Jason Xing wrote:
> > From: Jason Xing <kernelxing@tencent.com>
> >
> > SOF_TIMESTAMPING_RAW_HARDWARE is a report flag which passes the
> > timestamps generated by either SOF_TIMESTAMPING_TX_HARDWARE or
> > SOF_TIMESTAMPING_RX_HARDWARE to the userspace all the time.
> >
> > So let us revise the doc here.
> >
> > Link: Link: https://lore.kernel.org/all/66d8c21d3042a_163d93294cb@willemb.c.googlers.com.notmuch/

Something seems wrong with my macbook... Really strange

Ah, sorry, I have to repost it...

>
> nit: duplicate keyword
>
> > Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> > Reviewed-by: Willem de Bruijn <willemb@google.com>
>
> indeed

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-06 16:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-06  9:57 [PATCH net-next] net-timestamp: correct the use of SOF_TIMESTAMPING_RAW_HARDWARE Jason Xing
2024-09-06 15:26 ` Willem de Bruijn
2024-09-06 16:18   ` Jason Xing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).