* [PATCH net-next v1] net: atlantic: convert comma to semicolon
@ 2024-09-05 10:06 Yan Zhen
2024-09-06 10:43 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Yan Zhen @ 2024-09-05 10:06 UTC (permalink / raw)
To: irusskikh, davem, edumazet, kuba, pabeni
Cc: netdev, linux-kernel, opensource.kernel, Yan Zhen
Replace a comma between expression statements by a semicolon.
Signed-off-by: Yan Zhen <yanzhen@vivo.com>
---
drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
index f7433abd6..f21de0c21 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
@@ -557,7 +557,7 @@ static int __aq_ring_rx_clean(struct aq_ring_s *self, struct napi_struct *napi,
}
frag_cnt++;
- next_ = buff_->next,
+ next_ = buff_->next;
buff_ = &self->buff_ring[next_];
is_rsc_completed =
aq_ring_dx_in_range(self->sw_head,
@@ -583,7 +583,7 @@ static int __aq_ring_rx_clean(struct aq_ring_s *self, struct napi_struct *napi,
err = -EIO;
goto err_exit;
}
- next_ = buff_->next,
+ next_ = buff_->next;
buff_ = &self->buff_ring[next_];
buff_->is_cleaned = true;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v1] net: atlantic: convert comma to semicolon
2024-09-05 10:06 [PATCH net-next v1] net: atlantic: convert comma to semicolon Yan Zhen
@ 2024-09-06 10:43 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2024-09-06 10:43 UTC (permalink / raw)
To: Yan Zhen
Cc: irusskikh, davem, edumazet, kuba, pabeni, netdev, linux-kernel,
opensource.kernel
On Thu, Sep 05, 2024 at 06:06:19PM +0800, Yan Zhen wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>
Thanks,
This looks correct to me, although a bit more text in the patch description
would be nice.
That said, this duplicates a slightly earlier patch.
https://lore.kernel.org/all/20240904080845.1353144-1-nichen@iscas.ac.cn/
--
pw-bot: not-applicable
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-06 10:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-05 10:06 [PATCH net-next v1] net: atlantic: convert comma to semicolon Yan Zhen
2024-09-06 10:43 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).