From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: "Tomas Paukrt" <tomaspaukrt@email.cz>
Cc: <netdev@vger.kernel.org>, "Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Catalin Popescu" <catalin.popescu@leica-geosystems.com>,
"Simon Horman" <horms@kernel.org>
Subject: Re: [PATCH net v2] net: phy: dp83822: Fix NULL pointer dereference on DP83825 devices
Date: Fri, 6 Sep 2024 14:39:02 +0200 [thread overview]
Message-ID: <20240906143902.7fde7593@device-28.home> (raw)
In-Reply-To: <66w.ZbGt.65Ljx42yHo5.1csjxu@seznam.cz>
On Fri, 06 Sep 2024 12:52:40 +0200 (CEST)
"Tomas Paukrt" <tomaspaukrt@email.cz> wrote:
> The probe() function is only used for DP83822 and DP83826 PHY,
> leaving the private data pointer uninitialized for the DP83825 models
> which causes a NULL pointer dereference in the recently introduced/changed
> functions dp8382x_config_init() and dp83822_set_wol().
>
> Add the dp8382x_probe() function, so all PHY models will have a valid
> private data pointer to fix this issue and also prevent similar issues
> in the future.
>
> Fixes: 9ef9ecfa9e9f ("net: phy: dp8382x: keep WOL settings across suspends")
> Signed-off-by: Tomas Paukrt <tomaspaukrt@email.cz>
That looks OK to me. Note that you must wait 24h between iterations,
to give everyone a chance to review.
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Thanks,
Maxime
next prev parent reply other threads:[~2024-09-06 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 10:52 [PATCH net v2] net: phy: dp83822: Fix NULL pointer dereference on DP83825 devices Tomas Paukrt
2024-09-06 12:39 ` Maxime Chevallier [this message]
2024-09-10 23:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906143902.7fde7593@device-28.home \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=catalin.popescu@leica-geosystems.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tomaspaukrt@email.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox