From: Jakub Kicinski <kuba@kernel.org>
To: Yan Zhen <yanzhen@vivo.com>
Cc: marcin.s.wojtas@gmail.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, openkernel.kernel@vivo.com,
horms@kernel.org, David.Laight@aculab.com
Subject: Re: [PATCH net-next v1] net: mvneta: Avoid the misuse of the '_t' variants
Date: Fri, 6 Sep 2024 18:55:46 -0700 [thread overview]
Message-ID: <20240906185546.123b6d65@kernel.org> (raw)
In-Reply-To: <20240905063645.586354-1-yanzhen@vivo.com>
On Thu, 5 Sep 2024 14:36:45 +0800 Yan Zhen wrote:
> In this case if someone tries to set the tx_pending to 65536(0x10000),
> after forcing it to convert to u16, it becomes 0x0000, they will get
> the minimum supported size and not the maximum.
Core validates against tx_max_pending before calling the driver.
--
pw-bot: reject
prev parent reply other threads:[~2024-09-07 1:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 6:36 [PATCH net-next v1] net: mvneta: Avoid the misuse of the '_t' variants Yan Zhen
2024-09-05 8:30 ` David Laight
2024-09-07 1:55 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906185546.123b6d65@kernel.org \
--to=kuba@kernel.org \
--cc=David.Laight@aculab.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.s.wojtas@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=openkernel.kernel@vivo.com \
--cc=pabeni@redhat.com \
--cc=yanzhen@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).