From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
Sean Anderson <sean.anderson@linux.dev>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Willem de Bruijn <willemb@google.com>,
linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding
Date: Mon, 9 Sep 2024 16:51:16 -0700 [thread overview]
Message-ID: <20240909165116.1bdb4757@kernel.org> (raw)
In-Reply-To: <66df2fd2d6595_3bff929459@willemb.c.googlers.com.notmuch>
On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote:
> > This seems to be a bug in the driver.
> >
> > A call to skb_put_padto(skb, ETH_ZLEN) should be added.
>
> In which case this test detecting it may be nice to have, for lack of
> a more targeted test.
IIUC we're basically saying that we don't need to trim because pad
should be 0? In that case maybe let's keep the patch but add a check
on top which scans the pad for non-zero bytes, and print an informative
warning?
next prev parent reply other threads:[~2024-09-09 23:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 21:07 [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding Sean Anderson
2024-09-07 2:05 ` Willem de Bruijn
2024-09-09 15:02 ` Sean Anderson
2024-09-09 15:06 ` Willem de Bruijn
2024-09-09 15:09 ` Eric Dumazet
2024-09-09 17:26 ` Willem de Bruijn
2024-09-09 23:51 ` Jakub Kicinski [this message]
2024-09-10 1:01 ` Willem de Bruijn
2024-09-10 14:29 ` Sean Anderson
2024-09-10 17:42 ` Willem de Bruijn
2024-09-10 17:52 ` Sean Anderson
2024-09-10 21:01 ` Willem de Bruijn
2024-09-11 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909165116.1bdb4757@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.anderson@linux.dev \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).