From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, "Jay Vosburgh" <jv@jvosburgh.net>,
"Andy Gospodarek" <andy@greyhouse.net>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Vincent Mailhol" <mailhol.vincent@wanadoo.fr>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Sudarsana Kalluru" <skalluru@marvell.com>,
"Manish Chopra" <manishc@marvell.com>,
"Michael Chan" <michael.chan@broadcom.com>,
"Pavan Chebbi" <pavan.chebbi@broadcom.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Sunil Goutham" <sgoutham@marvell.com>,
"Potnuri Bharat Teja" <bharat@chelsio.com>,
"Christian Benvenuti" <benve@cisco.com>,
"Satish Kharat" <satishkh@cisco.com>,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Wei Fang" <wei.fang@nxp.com>,
"Shenwei Wang" <shenwei.wang@nxp.com>,
"Clark Wang" <xiaoning.wang@nxp.com>,
"Dimitris Michailidis" <dmichail@fungible.com>,
"Yisen Zhuang" <yisen.zhuang@huawei.com>,
"Salil Mehta" <salil.mehta@huawei.com>,
"Jijie Shao" <shaojijie@huawei.com>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
"Marcin Wojtas" <marcin.s.wojtas@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Geetha sowjanya" <gakula@marvell.com>,
"Subbaraya Sundeep" <sbhatta@marvell.com>,
hariprasad <hkelam@marvell.com>,
"Ido Schimmel" <idosch@nvidia.com>,
"Petr Machata" <petrm@nvidia.com>,
"Bryan Whitehead" <bryan.whitehead@microchip.com>,
UNGLinuxDriver@microchip.com,
"Horatiu Vultur" <horatiu.vultur@microchip.com>,
"Lars Povlsen" <lars.povlsen@microchip.com>,
"Steen Hegelund" <Steen.Hegelund@microchip.com>,
"Daniel Machon" <daniel.machon@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Shannon Nelson" <shannon.nelson@amd.com>,
"Brett Creeley" <brett.creeley@amd.com>,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Edward Cree" <ecree.xilinx@gmail.com>,
"Martin Habets" <habetsm.xilinx@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Siddharth Vadapalli" <s-vadapalli@ti.com>,
"Roger Quadros" <rogerq@kernel.org>,
"MD Danish Anwar" <danishanwar@ti.com>,
"Linus Walleij" <linusw@kernel.org>,
"Imre Kaloz" <kaloz@openwrt.org>,
"Richard Cochran" <richardcochran@gmail.com>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
"Carolina Jubran" <cjubran@nvidia.com>,
"Rahul Rameshbabu" <rrameshbabu@nvidia.com>
Subject: Re: [PATCH net-next 14/16] net: stmmac: Remove setting of RX software timestamp
Date: Mon, 9 Sep 2024 17:48:04 -0700 [thread overview]
Message-ID: <20240909174804.6be54abd@kernel.org> (raw)
In-Reply-To: <20240906144632.404651-15-gal@nvidia.com>
On Fri, 6 Sep 2024 17:46:30 +0300 Gal Pressman wrote:
> The responsibility for reporting of RX software timestamp has moved to
> the core layer (see __ethtool_get_ts_info()), remove usage from the
> device drivers.
>
> Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> index 7008219fd88d..a7b8407e898c 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> @@ -1207,13 +1207,13 @@ static int stmmac_get_ts_info(struct net_device *dev,
>
> info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
> SOF_TIMESTAMPING_TX_HARDWARE |
> - SOF_TIMESTAMPING_RX_SOFTWARE |
> SOF_TIMESTAMPING_RX_HARDWARE |
> - SOF_TIMESTAMPING_SOFTWARE |
> SOF_TIMESTAMPING_RAW_HARDWARE;
>
> if (priv->ptp_clock)
> info->phc_index = ptp_clock_index(priv->ptp_clock);
> + else
> + info->phc_index = 0;
Would have been good to explain the unusual change to phc_index
in the commit message.
next prev parent reply other threads:[~2024-09-10 0:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 14:46 [PATCH net-next 00/16] RX software timestamp for all - round 3 Gal Pressman
2024-09-06 14:46 ` [PATCH net-next 01/16] bnxt_en: Remove setting of RX software timestamp Gal Pressman
2024-09-07 18:08 ` Michael Chan
2024-09-08 7:53 ` Pavan Chebbi
2024-09-06 14:46 ` [PATCH net-next 02/16] tg3: " Gal Pressman
2024-09-07 18:13 ` Michael Chan
2024-09-08 7:52 ` Pavan Chebbi
2024-09-06 14:46 ` [PATCH net-next 03/16] bonding: " Gal Pressman
2024-09-06 14:46 ` [PATCH net-next 04/16] amd-xgbe: " Gal Pressman
2024-09-06 14:46 ` [PATCH net-next 05/16] net: macb: " Gal Pressman
2024-09-09 7:00 ` Nicolas Ferre
2024-09-06 14:46 ` [PATCH net-next 06/16] liquidio: " Gal Pressman
2024-09-06 14:46 ` [PATCH net-next 07/16] net: thunderx: " Gal Pressman
2024-09-06 14:46 ` [PATCH net-next 08/16] enic: " Gal Pressman
2024-09-06 14:46 ` [PATCH net-next 09/16] net/funeth: " Gal Pressman
2024-09-06 14:46 ` [PATCH net-next 10/16] net: mscc: ocelot: " Gal Pressman
2024-09-06 14:46 ` [PATCH net-next 11/16] qede: " Gal Pressman
2024-09-06 14:46 ` [PATCH net-next 12/16] sfc: " Gal Pressman
2024-09-06 14:46 ` [PATCH net-next 13/16] sfc/siena: " Gal Pressman
2024-09-06 14:46 ` [PATCH net-next 14/16] net: stmmac: " Gal Pressman
2024-09-10 0:48 ` Jakub Kicinski [this message]
2024-09-06 14:46 ` [PATCH net-next 15/16] ixp4xx_eth: " Gal Pressman
2024-09-07 5:48 ` Richard Cochran
2024-09-07 19:10 ` Linus Walleij
2024-09-06 14:46 ` [PATCH net-next 16/16] ptp: ptp_ines: " Gal Pressman
2024-09-10 0:50 ` [PATCH net-next 00/16] RX software timestamp for all - round 3 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909174804.6be54abd@kernel.org \
--to=kuba@kernel.org \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andy@greyhouse.net \
--cc=anthony.l.nguyen@intel.com \
--cc=benve@cisco.com \
--cc=bharat@chelsio.com \
--cc=brett.creeley@amd.com \
--cc=bryan.whitehead@microchip.com \
--cc=cjubran@nvidia.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=claudiu.manoil@nxp.com \
--cc=daniel.machon@microchip.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=dmichail@fungible.com \
--cc=ecree.xilinx@gmail.com \
--cc=gakula@marvell.com \
--cc=gal@nvidia.com \
--cc=habetsm.xilinx@gmail.com \
--cc=hkelam@marvell.com \
--cc=horatiu.vultur@microchip.com \
--cc=idosch@nvidia.com \
--cc=joabreu@synopsys.com \
--cc=jv@jvosburgh.net \
--cc=kaloz@openwrt.org \
--cc=lars.povlsen@microchip.com \
--cc=linusw@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mailhol.vincent@wanadoo.fr \
--cc=manishc@marvell.com \
--cc=marcin.s.wojtas@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.chan@broadcom.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=pavan.chebbi@broadcom.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=rogerq@kernel.org \
--cc=rrameshbabu@nvidia.com \
--cc=s-vadapalli@ti.com \
--cc=s.shtylyov@omp.ru \
--cc=salil.mehta@huawei.com \
--cc=satishkh@cisco.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=shannon.nelson@amd.com \
--cc=shaojijie@huawei.com \
--cc=shenwei.wang@nxp.com \
--cc=skalluru@marvell.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xiaoning.wang@nxp.com \
--cc=yisen.zhuang@huawei.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).