* [PATCH][next] rtase: Fix spelling mistake: "tx_underun" -> "tx_underrun"
@ 2024-09-09 13:46 Colin Ian King
2024-09-10 7:35 ` Simon Horman
2024-09-11 1:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2024-09-09 13:46 UTC (permalink / raw)
To: Justin Lai, Larry Chiu, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev
Cc: kernel-janitors, linux-kernel
There is a spelling mistake in the struct field tx_underun, rename
it to tx_underrun.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/ethernet/realtek/rtase/rtase_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
index 7882f2c0e1a4..869183e1565e 100644
--- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
+++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
@@ -98,7 +98,7 @@ struct rtase_counters {
__le64 rx_broadcast;
__le32 rx_multicast;
__le16 tx_aborted;
- __le16 tx_underun;
+ __le16 tx_underrun;
} __packed;
static void rtase_w8(const struct rtase_private *tp, u16 reg, u8 val8)
@@ -1619,8 +1619,8 @@ static void rtase_dump_state(const struct net_device *dev)
le32_to_cpu(counters->rx_multicast));
netdev_err(dev, "tx_aborted %d\n",
le16_to_cpu(counters->tx_aborted));
- netdev_err(dev, "tx_underun %d\n",
- le16_to_cpu(counters->tx_underun));
+ netdev_err(dev, "tx_underrun %d\n",
+ le16_to_cpu(counters->tx_underrun));
}
static void rtase_tx_timeout(struct net_device *dev, unsigned int txqueue)
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] rtase: Fix spelling mistake: "tx_underun" -> "tx_underrun"
2024-09-09 13:46 [PATCH][next] rtase: Fix spelling mistake: "tx_underun" -> "tx_underrun" Colin Ian King
@ 2024-09-10 7:35 ` Simon Horman
2024-09-11 1:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-09-10 7:35 UTC (permalink / raw)
To: Colin Ian King
Cc: Justin Lai, Larry Chiu, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, kernel-janitors,
linux-kernel
On Mon, Sep 09, 2024 at 02:46:12PM +0100, Colin Ian King wrote:
> There is a spelling mistake in the struct field tx_underun, rename
> it to tx_underrun.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Thanks Colin,
I've confirmed that this addresses all instances of this problem
in this driver. Thanks for also sending a patch for the same problem
in the r8169 driver [1].
Reviewed-by: Simon Horman <horms@kernel.org>
[1] https://lore.kernel.org/all/20240909140021.64884-1-colin.i.king@gmail.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] rtase: Fix spelling mistake: "tx_underun" -> "tx_underrun"
2024-09-09 13:46 [PATCH][next] rtase: Fix spelling mistake: "tx_underun" -> "tx_underrun" Colin Ian King
2024-09-10 7:35 ` Simon Horman
@ 2024-09-11 1:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-09-11 1:40 UTC (permalink / raw)
To: Colin Ian King
Cc: justinlai0215, larry.chiu, davem, edumazet, kuba, pabeni, netdev,
kernel-janitors, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 9 Sep 2024 14:46:12 +0100 you wrote:
> There is a spelling mistake in the struct field tx_underun, rename
> it to tx_underrun.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/net/ethernet/realtek/rtase/rtase_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Here is the summary with links:
- [next] rtase: Fix spelling mistake: "tx_underun" -> "tx_underrun"
https://git.kernel.org/netdev/net-next/c/d59239f8a400
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-11 1:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-09 13:46 [PATCH][next] rtase: Fix spelling mistake: "tx_underun" -> "tx_underrun" Colin Ian King
2024-09-10 7:35 ` Simon Horman
2024-09-11 1:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).