From: Jakub Kicinski <kuba@kernel.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Michal Simek <michal.simek@amd.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Andy Chiu <andy.chiu@sifive.com>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH net v2] net: xilinx: axienet: Fix packet counting
Date: Tue, 10 Sep 2024 07:39:56 -0700 [thread overview]
Message-ID: <20240910073956.53278ffe@kernel.org> (raw)
In-Reply-To: <318a13f6-da2d-4ba4-a51c-2f8444444bbf@linux.dev>
On Tue, 10 Sep 2024 10:24:36 -0400 Sean Anderson wrote:
> > why are you doing this? To make sure drivers doesn't complete more
> > than "budget" Tx skbs? The budget is really for Rx, for Tx you can
> > use a reasonable fixed value, independent of what budget core
> > passes in, e.g. 128. See:
> > https://www.kernel.org/doc/html/next/networking/napi.html#datapath-api
>
> I read this but it was unclear to me because it seems oriented towards
> "combined" NAPI instances, while we have separate instances for RX and
> TX. So even for TX-only instances, we can ignore budget?
Yes, combined or dedicated it should still reap completions regardless
of budget.
> > Moving this chunk into axienet_free_tx_chain() is a noop, right?
> > Please avoid code cleanups in fixes.
>
> The relevant variable (number of descriptors handled) is no longer
> returned to axienet_tx_poll, so it can't update the current descriptor
> properly.
Got it, worth mentioning in the commit msg.
prev parent reply other threads:[~2024-09-10 14:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 16:42 [PATCH net v2] net: xilinx: axienet: Fix packet counting Sean Anderson
2024-09-06 17:44 ` Pandey, Radhey Shyam
2024-09-06 17:49 ` Sean Anderson
2024-09-10 1:00 ` Jakub Kicinski
2024-09-10 14:24 ` Sean Anderson
2024-09-10 14:39 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910073956.53278ffe@kernel.org \
--to=kuba@kernel.org \
--cc=andy.chiu@sifive.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).