From: Simon Horman <horms@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, gospo@broadcom.com,
selvin.xavier@broadcom.com, pavan.chebbi@broadcom.com,
Somnath Kotur <somnath.kotur@broadcom.com>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
Andy Gospodarek <andrew.gospodarek@broadcom.com>
Subject: Re: [PATCH net-next 2/3] bnxt_en: Add MSIX check in bnxt_check_rings()
Date: Tue, 10 Sep 2024 09:34:10 +0100 [thread overview]
Message-ID: <20240910083410.GE525413@kernel.org> (raw)
In-Reply-To: <20240909202737.93852-3-michael.chan@broadcom.com>
On Mon, Sep 09, 2024 at 01:27:36PM -0700, Michael Chan wrote:
> bnxt_check_rings() is called to ensure that we have the hardware ring
> resources before committing to reinitialize with the new number of
> rings. MSIX vectors are never checked at this point, because up
> until recently we must first disable MSIX before we can allocate the
> new set of MSIX vectors.
>
> Now that we support dynamic MSIX allocation, check to make sure we
> can dynamically allocate the new MSIX vectors as the last step in
> bnxt_check_rings() if dynamic MSIX is supported.
>
> For example, the IOMMU group may limit the number of MSIX vectors
> for the device. With this patch, the ring change will fail more
> gracefully when there is not enough MSIX vectors.
>
> It is also better to move bnxt_check_rings() to be called as the last
> step when changing ethtool rings.
>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Andy Gospodarek <andrew.gospodarek@broadcom.com>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-09-10 8:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 20:27 [PATCH net-next 0/3] bnxt_en: MSIX improvements Michael Chan
2024-09-09 20:27 ` [PATCH net-next 1/3] bnxt_en: Increase the number of MSIX vectors for RoCE device Michael Chan
2024-09-10 8:33 ` Simon Horman
2024-09-09 20:27 ` [PATCH net-next 2/3] bnxt_en: Add MSIX check in bnxt_check_rings() Michael Chan
2024-09-10 8:34 ` Simon Horman [this message]
2024-09-09 20:27 ` [PATCH net-next 3/3] bnxt_en: resize bnxt_irq name field to fit format string Michael Chan
2024-09-10 8:34 ` Simon Horman
2024-09-11 2:10 ` [PATCH net-next 0/3] bnxt_en: MSIX improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910083410.GE525413@kernel.org \
--to=horms@kernel.org \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=selvin.xavier@broadcom.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).