From: Simon Horman <horms@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, Matthew Wood <thepacketgeek@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davej@codemonkey.org.uk, vlad.wing@gmail.com, max@kutsevol.com
Subject: Re: [PATCH net-next v3 10/10] net: netconsole: fix wrong warning
Date: Tue, 10 Sep 2024 15:50:06 +0100 [thread overview]
Message-ID: <20240910145006.GE572255@kernel.org> (raw)
In-Reply-To: <20240910100410.2690012-11-leitao@debian.org>
On Tue, Sep 10, 2024 at 03:04:05AM -0700, Breno Leitao wrote:
> A warning is triggered when there is insufficient space in the buffer
> for userdata. However, this is not an issue since userdata will be sent
> in the next iteration.
>
> Current warning message:
>
> ------------[ cut here ]------------
> WARNING: CPU: 13 PID: 3013042 at drivers/net/netconsole.c:1122 write_ext_msg+0x3b6/0x3d0
> ? write_ext_msg+0x3b6/0x3d0
> console_flush_all+0x1e9/0x330
>
> The code incorrectly issues a warning when this_chunk is zero, which is
> a valid scenario. The warning should only be triggered when this_chunk
> is negative.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> Fixes: 1ec9daf95093 ("net: netconsole: append userdata to fragmented netconsole messages")
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2024-09-10 14:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 10:03 [PATCH net-next v3 00/10] netconsole refactoring and warning fix Breno Leitao
2024-09-10 10:03 ` [PATCH net-next v3 01/10] net: netconsole: remove msg_ready variable Breno Leitao
2024-09-10 10:03 ` [PATCH net-next v3 02/10] net: netconsole: split send_ext_msg_udp() function Breno Leitao
2024-09-10 10:03 ` [PATCH net-next v3 03/10] net: netconsole: separate fragmented message handling in send_ext_msg Breno Leitao
2024-09-15 14:58 ` Jakub Kicinski
2024-09-15 18:19 ` Simon Horman
2024-09-16 8:49 ` Breno Leitao
2024-09-10 10:03 ` [PATCH net-next v3 04/10] net: netconsole: rename body to msg_body Breno Leitao
2024-09-10 10:04 ` [PATCH net-next v3 05/10] net: netconsole: introduce variable to track body length Breno Leitao
2024-09-10 10:04 ` [PATCH net-next v3 06/10] net: netconsole: track explicitly if msgbody was written to buffer Breno Leitao
2024-09-15 15:00 ` Jakub Kicinski
2024-09-10 10:04 ` [PATCH net-next v3 07/10] net: netconsole: extract release appending into separate function Breno Leitao
2024-09-10 10:04 ` [PATCH net-next v3 08/10] net: netconsole: do not pass userdata up to the tail Breno Leitao
2024-09-10 15:39 ` Simon Horman
2024-09-10 10:04 ` [PATCH net-next v3 09/10] net: netconsole: split send_msg_fragmented Breno Leitao
2024-09-10 10:04 ` [PATCH net-next v3 10/10] net: netconsole: fix wrong warning Breno Leitao
2024-09-10 14:50 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910145006.GE572255@kernel.org \
--to=horms@kernel.org \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@kutsevol.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thepacketgeek@gmail.com \
--cc=vlad.wing@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).