From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A0FD224CF for ; Wed, 11 Sep 2024 03:00:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726023648; cv=none; b=uufQcrVDioABqtHUT/oLonfL5p0OWrj/IArwuAYlhJ1gyvVxZ0vnQHDWOJO7SdVqIjr2g6WUQ+tElkvkTeIinqPWtqe1mZkgkQ5Rkadh7Lx+/JsVNX302kmxeVQr4CM6/fDGWV06bSdiYkskorM0vPO7iLxUbuNBIahSo37KC9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726023648; c=relaxed/simple; bh=KuGV1rIufI5kF4uh/ybrLUwlPr6FgJdhDUHHdr0r4M4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jWGpia8utJlx15O70WLSOH/kvQXaQKpK6vqLMfk5EEKwlyhIV7hc0dx2yyVUAbc744ebndSofl/qtLaiVaaA6wG/BktErqJE9eCOP0cPnQGOSrtxlz2dVAVk3QZu5QrmJi36IpPZ+WG/4TcWio1KkEp/p4NIGGTNwfwi1qfuHX8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AtcCZsxA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AtcCZsxA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 453DAC4CEC3; Wed, 11 Sep 2024 03:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726023647; bh=KuGV1rIufI5kF4uh/ybrLUwlPr6FgJdhDUHHdr0r4M4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AtcCZsxAjOxgJEnuZjOQTnJGwh0Un5xtDDKFeYb9AP9Cc/2Aa3bt/NO5U7Zld7niT LIvP2PaXmQp8sQRyM5RAtrc5V/m9b78GlR+6gL0pJJw3bQkW8v8lFrNsehITQVOFZO OKLdydE4PHXGQ7kki4Hitr15ZcUGEz/xzEbQhNC/oZ93XsGYurqd3iaJ9baxdBdRyd Y87IlvpOaAaC+WcC4VhqlShgW+ktLBeNOX1Z9TxxshcYJeSluylEwOcFh+KCt33DD/ DhPiL2nP7zTph9L1s+2lyoy/pbeZq2IJNLb/Tk7YUP+eDg90SWtfkVo3nkDu1XjYlc lRBKcpYwLkthA== Date: Tue, 10 Sep 2024 20:00:46 -0700 From: Jakub Kicinski To: Saeed Mahameed Cc: "David S. Miller" , Paolo Abeni , Eric Dumazet , Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Gal Pressman , Leon Romanovsky , Yevgeny Kliteynik , Erez Shitrit Subject: Re: [net-next V4 15/15] net/mlx5: HWS, added API and enabled HWS support Message-ID: <20240910200046.30df2803@kernel.org> In-Reply-To: <20240909181250.41596-16-saeed@kernel.org> References: <20240909181250.41596-1-saeed@kernel.org> <20240909181250.41596-16-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 9 Sep 2024 11:12:48 -0700 Saeed Mahameed wrote: > +/* Set a peer context, each context can have multiple contexts as peers. > + * > + * @param[in] ctx > + * The context in which the peer_ctx will be peered to it. > + * @param[in] peer_ctx > + * The peer context. > + * @param[in] peer_vhca_id > + * The peer context vhca id. > + */ I'm going to pull, but why are you not using kdoc comment format? Would be great if you could follow up and convert these.