From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F7FD13CF9C; Wed, 11 Sep 2024 07:34:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726040089; cv=none; b=NtH4nw30yIy+/KxrhxzaxMo1/Tu23LXV0mt5FqQiuDaCD4WvKrxzli9+mW61XuvyExd0rZYYdVTEm3K6kVK6x7Vxb8pzCD7ntlhRqWjbgNDlDESBDoiMxLRR+APq+nIzBQlO2nORvcZCVs14k2UWv6rYakraJQktnz09VvR4ivs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726040089; c=relaxed/simple; bh=sLTAmujLBBEb6mPMznNYykNiEq0ccUHvfasd/iof3Ic=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BUKqz0WJFBJoy/c4rYAwsGUjdjVa56z1VRjoxSuBltW68fPWYJNo7Ved4eMGOHYr/wts4yYRy0uqtYGH1l5iSS2CkBmvhcVRWjoarWOWoaDgAQO5JmYVi2C1DlZ0J803IAZRuSV4Grz4wsCZAcfUp3ZzQT6imghSXpU24qby+6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VAffp/gg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VAffp/gg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5E7FC4CEC6; Wed, 11 Sep 2024 07:34:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726040088; bh=sLTAmujLBBEb6mPMznNYykNiEq0ccUHvfasd/iof3Ic=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VAffp/ggG0vRk0ayKQkVa8R7o7MBQefoN13SyAk+lv9SaHLOU6WW9lUpIMXEg/sZ8 Aq3v6tEfuLd4rz8wSK0OeRe3sLWfnLP/hLKWq0txW4q4876kvyJxqAjTBqlDWdHr1C 0ClY08UkbWJhF0aXI7Z+lS6Kve2RbQuM9Q49i2De9jBXcVhlQIWCm2xt33NJbFJpSl bC6G2yuNSjriRJu8cEZCo8qytUN6yloWPCKp9jphj6ZBXZHcPCb8Pu15zI41d2rkJi MqgG9ia3f0hMKnBozntPtjhjNcHqSl+LONwWjOQHskpgjA49hgJBO5qoOjyOHrOK7D ZMOE+TINgOteA== Date: Wed, 11 Sep 2024 08:34:44 +0100 From: Simon Horman To: Jiawen Wu Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, rmk+kernel@armlinux.org.uk, mengyuanlou@net-swift.com, duanqiangwen@net-swift.com, stable@vger.kernel.org Subject: Re: [PATCH net] net: libwx: fix number of Rx and Tx descriptors Message-ID: <20240911073444.GL572255@kernel.org> References: <20240910095629.570674-1-jiawenwu@trustnetic.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240910095629.570674-1-jiawenwu@trustnetic.com> On Tue, Sep 10, 2024 at 05:56:29PM +0800, Jiawen Wu wrote: > The number of transmit and receive descriptors must be a multiple of 128 > due to the hardware limitation. If it is set to a multiple of 8 instead of > a multiple 128, the queues will easily be hung. > > Cc: stable@vger.kernel.org > Fixes: 883b5984a5d2 ("net: wangxun: add ethtool_ops for ring parameters") > Signed-off-by: Jiawen Wu Reviewed-by: Simon Horman