From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Andrew Lunn <andrew@lunn.ch>, David Ahern <dsahern@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Alexander Duyck <alexanderduyck@fb.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/5] eth: fbnic: add initial PHC support
Date: Wed, 11 Sep 2024 13:10:35 -0700 [thread overview]
Message-ID: <20240911131035.74c5e8f9@kernel.org> (raw)
In-Reply-To: <c1003a1b-cf6f-4332-b0c7-5461a164097e@linux.dev>
On Wed, 11 Sep 2024 20:49:51 +0100 Vadim Fedorenko wrote:
> >> + * TBD: alias u64_stats_sync & co. with some more appropriate names upstream.
> >
> > This is upstream, so maybe now is a good time to decide?
>
> That's good question. Do we need another set of helpers just because of
> names? Obviously, the internals will be the same sequence magic.
Good question. To be clear we want a seq lock that goes away on 64b
since what it protects is accessed on the fast path (potentially per
packet). We could s/u64_stats/u64_seq/ the existing helpers. But that
sounds like a lot for a single user. Dunno..
next prev parent reply other threads:[~2024-09-11 20:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 12:45 [PATCH net-next 0/5] eth: fbnic: add timestamping support Vadim Fedorenko
2024-09-11 12:45 ` [PATCH net-next 1/5] eth: fbnic: add software TX " Vadim Fedorenko
2024-09-11 18:48 ` Jakub Kicinski
2024-09-11 12:45 ` [PATCH net-next 2/5] eth: fbnic: add initial PHC support Vadim Fedorenko
2024-09-11 16:25 ` Andrew Lunn
2024-09-11 18:47 ` Jakub Kicinski
2024-09-11 19:49 ` Vadim Fedorenko
2024-09-11 20:10 ` Jakub Kicinski [this message]
2024-09-11 20:45 ` Andrew Lunn
2024-09-11 22:25 ` Jakub Kicinski
2024-09-11 12:45 ` [PATCH net-next 3/5] eth: fbnic: add RX packets timestamping support Vadim Fedorenko
2024-09-11 12:45 ` [PATCH net-next 4/5] eth: fbnic: add TX " Vadim Fedorenko
2024-09-11 12:45 ` [PATCH net-next 5/5] eth: fbnic: add ethtool timestamping statistics Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911131035.74c5e8f9@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).