* [PATCHv2 net-next] net: gianfar: fix NVMEM mac address
@ 2024-09-10 22:09 Rosen Penev
2024-09-11 14:30 ` Simon Horman
2024-09-12 0:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Rosen Penev @ 2024-09-10 22:09 UTC (permalink / raw)
To: netdev
Cc: andrew, davem, edumazet, kuba, pabeni, linux-kernel,
jacob.e.keller, horms, sd, chunkeey
If nvmem loads after the ethernet driver, mac address assignments will
not take effect. of_get_ethdev_address returns EPROBE_DEFER in such a
case so we need to handle that to avoid eth_hw_addr_random.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
v2: use goto instead of return
---
drivers/net/ethernet/freescale/gianfar.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
index 2baef59f741d..ecb1703ea150 100644
--- a/drivers/net/ethernet/freescale/gianfar.c
+++ b/drivers/net/ethernet/freescale/gianfar.c
@@ -754,6 +754,8 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev)
priv->device_flags |= FSL_GIANFAR_DEV_HAS_BUF_STASHING;
err = of_get_ethdev_address(np, dev);
+ if (err == -EPROBE_DEFER)
+ goto err_grp_init;
if (err) {
eth_hw_addr_random(dev);
dev_info(&ofdev->dev, "Using random MAC address: %pM\n", dev->dev_addr);
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCHv2 net-next] net: gianfar: fix NVMEM mac address
2024-09-10 22:09 [PATCHv2 net-next] net: gianfar: fix NVMEM mac address Rosen Penev
@ 2024-09-11 14:30 ` Simon Horman
2024-09-12 0:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-09-11 14:30 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, andrew, davem, edumazet, kuba, pabeni, linux-kernel,
jacob.e.keller, sd, chunkeey
On Tue, Sep 10, 2024 at 03:09:13PM -0700, Rosen Penev wrote:
> If nvmem loads after the ethernet driver, mac address assignments will
> not take effect. of_get_ethdev_address returns EPROBE_DEFER in such a
> case so we need to handle that to avoid eth_hw_addr_random.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> v2: use goto instead of return
Thanks for the update.
Reviewed-by: Simon Horman <horms@kernel.org>
...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2 net-next] net: gianfar: fix NVMEM mac address
2024-09-10 22:09 [PATCHv2 net-next] net: gianfar: fix NVMEM mac address Rosen Penev
2024-09-11 14:30 ` Simon Horman
@ 2024-09-12 0:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-09-12 0:10 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, andrew, davem, edumazet, kuba, pabeni, linux-kernel,
jacob.e.keller, horms, sd, chunkeey
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 10 Sep 2024 15:09:13 -0700 you wrote:
> If nvmem loads after the ethernet driver, mac address assignments will
> not take effect. of_get_ethdev_address returns EPROBE_DEFER in such a
> case so we need to handle that to avoid eth_hw_addr_random.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> v2: use goto instead of return
>
> [...]
Here is the summary with links:
- [PATCHv2,net-next] net: gianfar: fix NVMEM mac address
https://git.kernel.org/netdev/net-next/c/b2d9544070d0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-12 0:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-10 22:09 [PATCHv2 net-next] net: gianfar: fix NVMEM mac address Rosen Penev
2024-09-11 14:30 ` Simon Horman
2024-09-12 0:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).