From: Jakub Kicinski <kuba@kernel.org>
To: Taehee Yoo <ap420073@gmail.com>
Cc: Brett Creeley <bcreeley@amd.com>,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
corbet@lwn.net, michael.chan@broadcom.com,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
ecree.xilinx@gmail.com, przemyslaw.kitszel@intel.com,
andrew@lunn.ch, hkallweit1@gmail.com, kory.maincent@bootlin.com,
ahmed.zaki@intel.com, paul.greenwalt@intel.com,
rrameshbabu@nvidia.com, idosch@nvidia.com,
maxime.chevallier@bootlin.com, danieller@nvidia.com,
aleksander.lobakin@intel.com,
Andy Gospodarek <andrew.gospodarek@broadcom.com>
Subject: Re: [PATCH net-next v2 1/4] bnxt_en: add support for rx-copybreak ethtool command
Date: Wed, 11 Sep 2024 17:22:51 -0700 [thread overview]
Message-ID: <20240911172251.4d57b851@kernel.org> (raw)
In-Reply-To: <CAMArcTVH9fRU3kHf8g4U+e3fawMGiBNy1UctWG1Ni5rS=x6QQA@mail.gmail.com>
On Thu, 12 Sep 2024 00:53:31 +0900 Taehee Yoo wrote:
> > if (netif_running(dev)) {
> > bnxt_close_nic(bp, false, false);
> > bp->rx_copybreak = rx_copybreak;
> > bnxt_set_ring_params(bp);
> > bnxt_open_nic(bp, false, false);
> > } else {
> > bp->rx_copybreak = rx_copybreak;
> > }
>
> I think your suggestion is much safer!
> I will use your suggestion in the v3 patch.
This is better but Andy mentioned on another thread that queue reset
should work, so instead of full close / open maybe we can just do:
for (/* all Rx queues */) {
bnxt_queue_stop();
bnxt_queue_start();
}
when the device is already running?
next prev parent reply other threads:[~2024-09-12 0:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 14:55 [PATCH net-next v2 0/4] bnxt_en: implement tcp-data-split ethtool command Taehee Yoo
2024-09-11 14:55 ` [PATCH net-next v2 1/4] bnxt_en: add support for rx-copybreak " Taehee Yoo
2024-09-11 15:36 ` Brett Creeley
2024-09-11 15:53 ` Taehee Yoo
2024-09-12 0:22 ` Jakub Kicinski [this message]
2024-09-12 0:47 ` Michael Chan
2024-09-11 14:55 ` [PATCH net-next v2 2/4] bnxt_en: add support for tcp-data-split " Taehee Yoo
2024-09-11 14:55 ` [PATCH net-next v2 3/4] ethtool: Add support for configuring tcp-data-split-thresh Taehee Yoo
2024-09-11 15:26 ` Kory Maincent
2024-09-11 15:42 ` Taehee Yoo
2024-09-11 15:47 ` Brett Creeley
2024-09-11 16:03 ` Taehee Yoo
2024-09-11 16:06 ` Brett Creeley
2024-09-11 16:51 ` Samudrala, Sridhar
2024-09-12 0:31 ` Jakub Kicinski
2024-09-12 15:42 ` Samudrala, Sridhar
2024-09-11 14:55 ` [PATCH net-next v2 4/4] bnxt_en: add support for tcp-data-split-thresh ethtool command Taehee Yoo
2024-09-11 15:52 ` Brett Creeley
2024-09-11 16:32 ` Taehee Yoo
2024-09-11 17:34 ` Brett Creeley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911172251.4d57b851@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=andrew@lunn.ch \
--cc=ap420073@gmail.com \
--cc=bcreeley@amd.com \
--cc=corbet@lwn.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=idosch@nvidia.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-doc@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rrameshbabu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).