From: Simon Horman <horms@kernel.org>
To: Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc: John Stultz <jstultz@google.com>,
Frederic Weisbecker <frederic@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Miroslav Lichvar <mlichvar@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Christopher S Hall <christopher.s.hall@intel.com>
Subject: Re: [PATCH 10/24] timekeeping: Define a struct type for tk_core to make it reusable
Date: Thu, 12 Sep 2024 08:38:28 +0100 [thread overview]
Message-ID: <20240912073828.GC572255@kernel.org> (raw)
In-Reply-To: <20240911-devel-anna-maria-b4-timers-ptp-timekeeping-v1-10-f7cae09e25d6@linutronix.de>
On Wed, Sep 11, 2024 at 03:29:54PM +0200, Anna-Maria Behnsen wrote:
> The struct tk_core uses is not reusable. As long as there is only a single
> timekeeper, this is not a problem. But when the timekeeper infrastructure
> will be reused for per ptp clock timekeepers, an explicit struct type is
> required.
>
> Define struct tk_data as explicit struct type for tk_core.
>
> Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
...
Hi Anna-Maria,
I wonder if the order of this and the previous patch should
be reversed, or the two patches should be squashed together.
I am seeing a build failure with only patches 01-09/24 of this series
applied, which seem to be resolved by applying this patch.
.../timekeeping.c:1735:43: warning: declaration of 'struct tk_data' will not be visible outside of this function [-Wvisibility]
1735 | static __init void tkd_basic_setup(struct tk_data *tkd)
...
next prev parent reply other threads:[~2024-09-12 7:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 13:29 [PATCH 00/24] timekeeping: Rework to prepare support of indenpendent PTP clocks Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 01/24] timekeeping: Read NTP tick length only once Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 02/24] timekeeping: Don't stop time readers across hard_pps() update Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 03/24] timekeeping: Avoid duplicate leap state update Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 04/24] timekeeping: Abort clocksource change in case of failure Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 05/24] timekeeping: Simplify code in timekeeping_advance() Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 06/24] timekeeping: Reorder struct timekeeper Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 07/24] timekeeping: Move shadow_timekeeper into tk_core Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 08/24] timekeeping: Encapsulate locking/unlocking of timekeeper_lock Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 09/24] timekeeping: Move timekeeper_lock into tk_core Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 10/24] timekeeping: Define a struct type for tk_core to make it reusable Anna-Maria Behnsen
2024-09-12 7:38 ` Simon Horman [this message]
2024-09-13 9:16 ` Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 11/24] timekeeping: Add struct tk_data as argument to timekeeping_update() Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 12/24] timekeeping: Split out timekeeper update of timekeeping_advanced() Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 13/24] timekeeping: Introduce combined timekeeping action flag Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 14/24] timekeeping: Provide timekeeping_restore_shadow() Anna-Maria Behnsen
2024-09-11 13:29 ` [PATCH 15/24] timekeeping: Rework do_settimeofday64() to use shadow_timekeeper Anna-Maria Behnsen
2024-09-11 13:30 ` [PATCH 16/24] timekeeping: Rework timekeeping_inject_offset() " Anna-Maria Behnsen
2024-09-11 13:30 ` [PATCH 17/24] timekeeping: Rework change_clocksource() " Anna-Maria Behnsen
2024-09-11 13:30 ` [PATCH 18/24] timekeeping: Rework timekeeping_init() " Anna-Maria Behnsen
2024-09-11 13:30 ` [PATCH 19/24] timekeeping: Rework timekeeping_inject_sleeptime64() " Anna-Maria Behnsen
2024-09-11 13:30 ` [PATCH 20/24] timekeeping: Rework timekeeping_resume() " Anna-Maria Behnsen
2024-09-11 13:30 ` [PATCH 21/24] timekeeping: Rework timekeeping_suspend() " Anna-Maria Behnsen
2024-09-11 13:30 ` [PATCH 22/24] timekeeping: Rework do_adjtimex() " Anna-Maria Behnsen
2024-09-11 13:30 ` [PATCH 23/24] timekeeping: Remove TK_MIRROR timekeeping_update() action Anna-Maria Behnsen
2024-09-11 13:30 ` [PATCH 24/24] timekeeping: Merge timekeeping_update_staged() and timekeeping_update() Anna-Maria Behnsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912073828.GC572255@kernel.org \
--to=horms@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=christopher.s.hall@intel.com \
--cc=frederic@kernel.org \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).