* [PATCH net-next] rtase: Fix error code in rtase_init_board()
@ 2024-09-12 8:57 Dan Carpenter
2024-09-12 11:23 ` Simon Horman
2024-09-14 4:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-09-12 8:57 UTC (permalink / raw)
To: Justin Lai
Cc: Larry Chiu, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-kernel, kernel-janitors
Return an error if dma_set_mask_and_coherent() fails. Don't return
success.
Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/net/ethernet/realtek/rtase/rtase_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
index 7882f2c0e1a4..ffebc67cba5a 100644
--- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
+++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
@@ -2023,7 +2023,8 @@ static int rtase_init_board(struct pci_dev *pdev, struct net_device **dev_out,
if (ret < 0)
goto err_out_disable;
- if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
+ ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
+ if (ret) {
dev_err(&pdev->dev, "no usable dma addressing method\n");
goto err_out_free_res;
}
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] rtase: Fix error code in rtase_init_board()
2024-09-12 8:57 [PATCH net-next] rtase: Fix error code in rtase_init_board() Dan Carpenter
@ 2024-09-12 11:23 ` Simon Horman
2024-09-14 4:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-09-12 11:23 UTC (permalink / raw)
To: Dan Carpenter
Cc: Justin Lai, Larry Chiu, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, linux-kernel,
kernel-janitors
On Thu, Sep 12, 2024 at 11:57:06AM +0300, Dan Carpenter wrote:
> Return an error if dma_set_mask_and_coherent() fails. Don't return
> success.
>
> Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] rtase: Fix error code in rtase_init_board()
2024-09-12 8:57 [PATCH net-next] rtase: Fix error code in rtase_init_board() Dan Carpenter
2024-09-12 11:23 ` Simon Horman
@ 2024-09-14 4:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-09-14 4:30 UTC (permalink / raw)
To: Dan Carpenter
Cc: justinlai0215, larry.chiu, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 12 Sep 2024 11:57:06 +0300 you wrote:
> Return an error if dma_set_mask_and_coherent() fails. Don't return
> success.
>
> Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/net/ethernet/realtek/rtase/rtase_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Here is the summary with links:
- [net-next] rtase: Fix error code in rtase_init_board()
https://git.kernel.org/netdev/net-next/c/37551b4540bd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-14 4:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-12 8:57 [PATCH net-next] rtase: Fix error code in rtase_init_board() Dan Carpenter
2024-09-12 11:23 ` Simon Horman
2024-09-14 4:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).