From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EB8118891D; Thu, 12 Sep 2024 23:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726184753; cv=none; b=ntW7pl3OzQXE6XeweO0rpiSxZ87w2hkMu53td3SjlC0bmWqJhzMLhT8pD9KN9Ub3O/fT+yaZfmrUvhKJ2NMTr91KU1KZCBl0GpMhHrG8XT8Bjq+WjCTr6XEJSA5aV1PaQertl+4S1UfdghsE3VDrN39aNtgSARO/EEJj0Kb/xgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726184753; c=relaxed/simple; bh=Uq0kkQVqpccg0BdoOMB4WvgRs+396QtDG1vIiaA8lb4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jxvYekMPJBF6v8kANUniE5EnZckzTngaZSHdmJegQVapmjXXtPMGVtzWP3SWZMsgZb6BBviKlIwKwgz5T9bUAMrSnnorJ2WZKiPM+1OcDKFCnr2vZpEDEz4F5KvxnloAhlVk28cQ8+9IqudpVedYaAWajbRWVSoRSB2Jf35Hyh0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OSZ7rY2+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OSZ7rY2+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2CC9C4CEC3; Thu, 12 Sep 2024 23:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726184753; bh=Uq0kkQVqpccg0BdoOMB4WvgRs+396QtDG1vIiaA8lb4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OSZ7rY2+aXDt0vXwwWW9KJ090mwIUS+k8dK1uwVNtg6gsF+oaO9ZLrknjSSvMxiK2 u+c0i64QPr3e3+0gws872UINBWAnQ5My7OQnvf/3ueI6AtBmoygbxTAUekMEyntUgV tUrI4leOZXZ3F512NxH3K63TuIftPrFvq1gvcP6ERhQKy7/g7VY/E6qTz/xqOZ22w6 kwFDlvVWkzOFR4pbpJx2BOJOToav1wOxC21H6CB9l3SDS3pb8WVtADzeOWy9yv/2r/ xaoQBYzPoD1uaAaozdjl2NvQrf3T7AvAmUunStwGPsl+1V7FkeJFGXr6fywcimxJd+ ufq63ojEpyb+A== Date: Thu, 12 Sep 2024 16:45:51 -0700 From: Jakub Kicinski To: Daniel Zahka Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] ethtool: rss: fix rss key initialization warning Message-ID: <20240912164551.3ce5b1a8@kernel.org> In-Reply-To: <20240912230531.3116582-1-daniel.zahka@gmail.com> References: <20240912230531.3116582-1-daniel.zahka@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 12 Sep 2024 16:05:30 -0700 Daniel Zahka wrote: > - WARN_ON_ONCE(!ret && !rxfh_dev.key && > + WARN_ON_ONCE(!ret && !rxfh_dev.key && ops->rxfh_per_ctx_key && wrap at 80 chars, please, make sure you read: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html before sending v2 -- pw-bot: cr