netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Qianqiang Liu <qianqiang.liu@163.com>
Cc: andrew@lunn.ch, o.rempel@pengutronix.de, rosenp@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ag71xx: remove dead code path
Date: Thu, 12 Sep 2024 17:36:35 -0700	[thread overview]
Message-ID: <20240912173635.20594e15@kernel.org> (raw)
In-Reply-To: <ZuMMyv9_npZ8txU8@iZbp1asjb3cy8ks0srf007Z>

On Thu, 12 Sep 2024 23:46:18 +0800 Qianqiang Liu wrote:
> Could you please review this patch?

My preference is to combine the removal with Oleksij's suggestion
of adding the drop/error increment at the right spot.
-- 
pw-bot: cr

      reply	other threads:[~2024-09-13  0:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-10 15:22 [PATCH] net: ag71xx: remove dead code path Qianqiang Liu
2024-09-10 15:58 ` Andrew Lunn
2024-09-11  7:53   ` Oleksij Rempel
2024-09-10 18:22 ` Rosen Penev
2024-09-12 15:46 ` Qianqiang Liu
2024-09-13  0:36   ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240912173635.20594e15@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=qianqiang.liu@163.com \
    --cc=rosenp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).