From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Lukasz Majewski <lukma@denx.de>
Subject: Re: [PATCH net 0/2] net: hsr: Use the seqnr lock for frames received via interlink port.
Date: Fri, 13 Sep 2024 08:43:29 +0200 [thread overview]
Message-ID: <20240913064329.mRHNdBGa@linutronix.de> (raw)
In-Reply-To: <20240912171413.4a81ab12@kernel.org>
On 2024-09-12 17:14:13 [-0700], Jakub Kicinski wrote:
> On Thu, 12 Sep 2024 08:51:55 +0200 Sebastian Andrzej Siewior wrote:
> > > The fix doesn't look super urgent and with a repost it won't have
> > > time to get into tomorrow's PR with fixes. So I just pushed them
> > > both into net-next.
> >
> > I just noticed that you applied
>
> Yeah, the plural "you", but still my bad for not putting two
> and two together :S
Oh I'm sorry, I didn't pay attention ;)
> > b3c9e65eb2272 ("net: hsr: remove seqnr_lock")
> >
> > to net. Patch 1/2 should replace that one and clashes with this one now.
> > I tried to explain that removing the lock and making it atomic can break
> > things again.
> > Should I send a revert of b3c9e65eb2272 to net?
>
> I have a potentially very stupid plan to squash the revert into
> the cross merge..
Whatever works best for you. I will probably send the revert+patch to
Greg for stable once he asks for it.
Sebastian
next prev parent reply other threads:[~2024-09-13 6:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 13:25 [PATCH net 0/2] net: hsr: Use the seqnr lock for frames received via interlink port Sebastian Andrzej Siewior
2024-09-06 13:25 ` [PATCH net 1/2] " Sebastian Andrzej Siewior
2024-09-09 9:49 ` Lukasz Majewski
2024-09-10 23:25 ` Jakub Kicinski
2024-09-11 7:54 ` Lukasz Majewski
2024-09-11 15:46 ` Lukasz Majewski
2024-09-06 13:25 ` [PATCH net-next 2/2] net: hsr: Remove interlink_sequence_nr Sebastian Andrzej Siewior
2024-09-09 9:43 ` Lukasz Majewski
2024-09-11 22:53 ` [PATCH net 0/2] net: hsr: Use the seqnr lock for frames received via interlink port Jakub Kicinski
2024-09-12 6:51 ` Sebastian Andrzej Siewior
2024-09-13 0:14 ` Jakub Kicinski
2024-09-13 6:43 ` Sebastian Andrzej Siewior [this message]
2024-09-11 23:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913064329.mRHNdBGa@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).