From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 614628F47 for ; Fri, 13 Sep 2024 14:42:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726238568; cv=none; b=UcLE3K6zT6w/GjwCWQSJoyOO8gN/3JazvTEnybBRv9ZRbk6AUs606jO9GICENA+KwgAVDc42SzdDLj20FEImpspKkRqdwuWqcvCsi7edOwhJ6ZaCmSDv7ciTNT4ESABztjQmfY5QOEEbdnNGX6jnXPtR/TGwq0nZMH4YAVB6mp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726238568; c=relaxed/simple; bh=nev9DihsAC8ocjNS3pSrj/VrEo50v0lYj9jPXLzN3dI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NDLIFuVQ15MKxZ8B96+iN6jloFrgad6mfrbYDotUI0wzq4DwJrKXl8BufZSrjlhbY68+MFLUsubclKUknLKuSUIxGzUtb2ZjEwIbjzivU5BgBIx3WBZ+fbd+lkQyAikm5Hco+UDY1iARe6DVj+1Ztrytcip96IRyGF95dGK42E4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UKz59ovc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UKz59ovc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8C3BC4CEC0; Fri, 13 Sep 2024 14:42:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726238568; bh=nev9DihsAC8ocjNS3pSrj/VrEo50v0lYj9jPXLzN3dI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UKz59ovcSBej7OtWtbRe0tbX50QcQpMQMs2wES6kA2DP7CSvFeUerkT7o3OT9x1vJ mMu7jell5l9ZFPriGIp4/s80uMUHagZ3ln4kJkDHF/fH5mhaBAWb1Ll7g824zptES+ nk8OxjGdT2XwxbGHDrgXL1nf87FzgH60sHI6IT4vzYjRjfagYnXVO4AjrJnjnQUlyH wd//uPyqSZE2a40aU9ZSeTACWbJCxFszdQXMeX9FF415Z9asESAvjISjot0cq9BhPz oCAje0bmYCHIUq81hx5xVh79RcFaj/B+ktWr2RqPr2dpnPf8IlpiQA6XDzns9FWnOF PpOPppV6G3d3g== Date: Fri, 13 Sep 2024 07:42:47 -0700 From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us Subject: Re: [PATCH net-next] net: sched: cls_api: improve the error message for ID allocation failure Message-ID: <20240913074247.4279a51d@kernel.org> In-Reply-To: <20240912215306.2060709-1-kuba@kernel.org> References: <20240912215306.2060709-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 12 Sep 2024 14:53:06 -0700 Jakub Kicinski wrote: > } else { > chain_info->next = NULL; > + NL_SET_ERR_MSG(extack, "Filter with specified priority/protocol not found"); > } I messed up here, the cases which handle NULL as success now print a warning. -- pw-bot: cr