From: Simon Horman <horms@kernel.org>
To: Kaixin Wang <kxwang23@m.fudan.edu.cn>
Cc: davem@davemloft.net, wtdeng24@m.fudan.edu.cn,
21210240012@m.fudan.edu.cn, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, edumazet@google.com,
kuba@kernel.org
Subject: Re: [PATCH] net: seeq: Fix use after free vulnerability in ether3 Driver Due to Race Condition
Date: Fri, 13 Sep 2024 12:37:27 +0100 [thread overview]
Message-ID: <20240913113727.GX572255@kernel.org> (raw)
In-Reply-To: <20240909175821.2047-1-kxwang23@m.fudan.edu.cn>
On Tue, Sep 10, 2024 at 01:58:21AM +0800, Kaixin Wang wrote:
> In the ether3_probe function, a timer is initialized with a callback
> function ether3_ledoff, bound to &prev(dev)->timer. Once the timer is
> started, there is a risk of a race condition if the module or device
> is removed, triggering the ether3_remove function to perform cleanup.
> The sequence of operations that may lead to a UAF bug is as follows:
>
> CPU0 CPU1
>
> | ether3_ledoff
> ether3_remove |
> free_netdev(dev); |
> put_devic |
> kfree(dev); |
> | ether3_outw(priv(dev)->regs.config2 |= CFG2_CTRLO, REG_CONFIG2);
> | // use dev
>
> Fix it by ensuring that the timer is canceled before proceeding with
> the cleanup in ether3_remove.
>
> Signed-off-by: Kaixin Wang <kxwang23@m.fudan.edu.cn>
This seems like it is a bug fix to me. If so, it should have a Fixes tag
(immediately above your Signed-off-by line, no blank line in between). And
be targeted at net.
Subject: [PATCH net] ...
Unless the bug only exists in net-next.
Subject: [PATCH net-next] ...
Link: https://docs.kernel.org/process/maintainer-netdev.html
...
prev parent reply other threads:[~2024-09-13 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 17:58 [PATCH] net: seeq: Fix use after free vulnerability in ether3 Driver Due to Race Condition Kaixin Wang
2024-09-11 9:29 ` Przemek Kitszel
2024-09-12 16:46 ` Kaixin Wang
2024-09-13 11:37 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913113727.GX572255@kernel.org \
--to=horms@kernel.org \
--cc=21210240012@m.fudan.edu.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kxwang23@m.fudan.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wtdeng24@m.fudan.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).