From: Jakub Kicinski <kuba@kernel.org>
To: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, shradhagupta@linux.microsoft.com,
ahmed.zaki@intel.com, colin.i.king@gmail.com,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mana: Add get_link and get_link_ksettings in ethtool
Date: Fri, 13 Sep 2024 20:23:47 -0700 [thread overview]
Message-ID: <20240913202347.2b74f75e@kernel.org> (raw)
In-Reply-To: <1726127083-28538-1-git-send-email-ernis@linux.microsoft.com>
On Thu, 12 Sep 2024 00:44:43 -0700 Erni Sri Satya Vennela wrote:
> Add support for the ethtool get_link and get_link_ksettings
> operations. Display standard port information using ethtool.
Any reason why? Sometimes people add this callback for virtual
devices to expose some approximate speed, but you're not reporting
speed, so I'm curious.
> +static int mana_get_link_ksettings(struct net_device *ndev,
> + struct ethtool_link_ksettings *cmd)
> +{
> + cmd->base.duplex = DUPLEX_FULL;
make sense
> + cmd->base.autoneg = AUTONEG_ENABLE;
what's the point of autoneg if we show no link info?
DISABLE seems more suitable
> + cmd->base.port = PORT_DA;
Any reason why DA? I'd think PORT_OTHER may be better?
--
pw-bot: cr
next prev parent reply other threads:[~2024-09-14 3:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 7:44 [PATCH] net: mana: Add get_link and get_link_ksettings in ethtool Erni Sri Satya Vennela
2024-09-14 3:23 ` Jakub Kicinski [this message]
2024-09-17 14:35 ` Haiyang Zhang
2024-09-17 15:04 ` Jakub Kicinski
2024-09-17 20:34 ` Haiyang Zhang
2024-09-19 7:45 ` Jakub Kicinski
2024-09-20 12:49 ` Erni Sri Satya Vennela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913202347.2b74f75e@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=ernis@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).