From: Simon Horman <horms@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: bryan.whitehead@microchip.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
anna-maria@linutronix.de, frederic@kernel.org,
tglx@linutronix.de, richardcochran@gmail.com,
UNGLinuxDriver@microchip.com, mbenes@suse.cz, jstultz@google.com,
andrew@lunn.ch, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next v4 1/2] posix-clock: Check timespec64 before call clock_settime()
Date: Sat, 14 Sep 2024 16:23:18 +0100 [thread overview]
Message-ID: <20240914152318.GC11774@kernel.org> (raw)
In-Reply-To: <20240914100625.414013-2-ruanjinjie@huawei.com>
On Sat, Sep 14, 2024 at 06:06:24PM +0800, Jinjie Ruan wrote:
> As Andrew pointed out, it will make sense that the PTP core
> checked timespec64 struct's tv_sec and tv_nsec range before calling
> ptp->info->settime64().
>
> As the man mannul of clock_settime() said, if tp.tv_sec is negative or
> tp.tv_nsec is outside the range [0..999,999,999], it shuld return EINVAL,
nit: should
Flagged by checkpatch.pl --codespell
...
next prev parent reply other threads:[~2024-09-14 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 10:06 [PATCH -next v4 0/2] posix-clock: Check timespec64 for PTP clock Jinjie Ruan
2024-09-14 10:06 ` [PATCH -next v4 1/2] posix-clock: Check timespec64 before call clock_settime() Jinjie Ruan
2024-09-14 15:23 ` Simon Horman [this message]
2024-10-02 15:18 ` Thomas Gleixner
2024-10-02 15:22 ` Thomas Gleixner
2024-09-14 10:06 ` [PATCH -next v4 2/2] net: lan743x: Remove duplicate check Jinjie Ruan
2024-09-14 13:56 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240914152318.GC11774@kernel.org \
--to=horms@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=anna-maria@linutronix.de \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=jstultz@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=ruanjinjie@huawei.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).