From: Simon Horman <horms@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Bryan Whitehead <bryan.whitehead@microchip.com>,
Raju Lakkaraju <Raju.Lakkaraju@microchip.com>,
UNGLinuxDriver@microchip.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: lan743x: clean up a check in lan743x_netdev_open()
Date: Sat, 14 Sep 2024 16:46:12 +0100 [thread overview]
Message-ID: <20240914154612.GG11774@kernel.org> (raw)
In-Reply-To: <f2483839-687f-4f30-b5fa-20eac90c1885@stanley.mountain>
On Sat, Sep 14, 2024 at 12:59:01PM +0300, Dan Carpenter wrote:
> The "adapter->netdev->phydev" and "netdev->phydev" pointers are different
> names for the same thing. Use them consistently. It makes the code more
> clear to humans and static checkers alike.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Hi Dan,
net-next is currently closed, other than for bug fixes.
So please repost this once it re-opens, after v6.12-rc1 is released.
> ---
> I noticed a different static checker warning that I never reported because it
> was too old. However, I think it's a valid issue.
> drivers/net/ethernet/microchip/lan743x_main.c:109 lan743x_pci_init() warn: missing error code 'ret'
> I think we should set an error code on that path. It disables the PCI device
> and then we continue to do PCI stuff even though the device is disabled.
Yes, I agree.
I tend to think that is a bug. Though perhaps
there is no urgency in fixing it as it seems unlikely
to occur in practice and it seems to date back to when the
driver was added in 2018 / v4.17.
commit 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
...
--
pw-bot: defer
prev parent reply other threads:[~2024-09-14 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 9:59 [PATCH net-next] net: lan743x: clean up a check in lan743x_netdev_open() Dan Carpenter
2024-09-14 15:46 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240914154612.GG11774@kernel.org \
--to=horms@kernel.org \
--cc=Raju.Lakkaraju@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=bryan.whitehead@microchip.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).