From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 701471CF92 for ; Sun, 15 Sep 2024 19:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726429719; cv=none; b=Gh/7G0LVQMd2CGIR7ydYBbg6XfxDHKLXpL3FZzkNCaygq5oFf2yt/l8H3qJ1w9JWXAI6aYUod0e/Eky0PfNLyHw7GrHqKFrbaUuGGOc/1+ca88SfMXIxHCcW5JeDPiZNo9c7hggJnH9KA2zI2YgJ5juuBNZiLhEu8Wnc9bMfTYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726429719; c=relaxed/simple; bh=MRhzl9kpuCHu74clIdzWjSROzs8qD6POOF2vur5Iqeg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=procgIdvZ9oX+eco4kLWngdHeuDin0Aix0PLQfvjHwP7PGUOwWPfstTd7ZzQ0Tx8IwmiNoNulqEbVKjgppQiq+TpDhy7GUt+Eo3DW5APL+VR9yh+Zd4qG8rkgb+KDluXnsLtvkKCu3aDOp2Kv1bRHQT47ithm1sa2UTA1I2ureI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=LegECz0X; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="LegECz0X" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2053525bd90so21619075ad.0 for ; Sun, 15 Sep 2024 12:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1726429717; x=1727034517; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SNp5/hnkOy9FrJ592XEPwxvQOfrqTwTwJ+m8OyrqXK0=; b=LegECz0Xauqv1hObdVLXz96DmYUwaRos6scUz0g55lMnTM1wT02MZaM10rpc3JEbhU +VlYnJMFFMWqPqsOt/A9pPEAyZ6T9F5bclTXMnDl71mF8X6ysZye/rPeV8/2pVHqFNDp g6Is8+mZSZH880h5F5IxVe0mpH20g4rQSGW1HRJM8p6uh44Dpx+l97XwGAeasKKq5L2O 9FZbzKSXf2+zn8a3GdDhTz54m9ImBEfDuzwhP7/dCHHbDw2lpLqVJj6Xv2/0Wm+9RoEm SQGTui91l5s3piY8IwK/9wH6HXu2kU4WDwLP66OqjGcIk9sXkebUjecAlKvRX/hBczLM d3lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726429717; x=1727034517; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SNp5/hnkOy9FrJ592XEPwxvQOfrqTwTwJ+m8OyrqXK0=; b=R3SGdliRxwwi9Yj565+PguY//7MomYGcy8KT/cLv2vNcL6wktmwTPIBz01glt/JYA2 iWsbZUGtvhAJSnd/fvnpJoWzXnqg4+GIEQEB7AD7q3beFbTg2q98CYT+KWM0uHNsTLW4 yKf+KfsryhAkTM3I3wcZzBItMy8j4p5VUJgME91FARAfBokp1Yqtqa/YKTLjLUy8Aubd lqAQLq/ypENXf3JWO9smLtXXmUln5CPX8AzQ1XyDXOfrgGUzcLn0Kxz6PAdiFo5mr4eL CEEB91oeEu9ytCRv2Ep/iIVnwEYnuAQih47F0TzNqET+5eBkxW23dpPSaqKl6dUKfO14 Wklg== X-Forwarded-Encrypted: i=1; AJvYcCW6xR82V2pZ9MCDme1XZbTUqwxJR1Ve9Pt79Hlcc1BVaxv3f6a6XDc6DNfRXgI92yGW6M2Y59I=@vger.kernel.org X-Gm-Message-State: AOJu0Yx73c2nelaGijt1V2VtjvAizPY3+AoT4lCRQyYEXnwbuYAOc+78 dQr6XlXWzgcG1kC+tXC3Zq4UcjVQdutpFIPdBAi33jQhMWuO4gWdMP4rk/SeDYQ= X-Google-Smtp-Source: AGHT+IEIwQjnGlDPb3oEceDakpD1b1PWW6LbBCx4i0kZt1Rli+HqyHRriIrHVS++Yfgo5DfOZzymmg== X-Received: by 2002:a17:903:32c9:b0:206:ae39:9f4 with SMTP id d9443c01a7336-20781d5f6fcmr138044405ad.20.1726429717591; Sun, 15 Sep 2024 12:48:37 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20794735719sm24738385ad.275.2024.09.15.12.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Sep 2024 12:48:37 -0700 (PDT) Date: Sun, 15 Sep 2024 12:48:35 -0700 From: Stephen Hemminger To: Akihiko Odaki Cc: Jonathan Corbet , Willem de Bruijn , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Michael S. Tsirkin" , Xuan Zhuo , Shuah Khan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kselftest@vger.kernel.org, Yuri Benditovich , Andrew Melnychenko Subject: Re: [PATCH RFC v3 0/9] tun: Introduce virtio-net hashing feature Message-ID: <20240915124835.456676f0@hermes.local> In-Reply-To: <20240915-rss-v3-0-c630015db082@daynix.com> References: <20240915-rss-v3-0-c630015db082@daynix.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 15 Sep 2024 10:17:39 +0900 Akihiko Odaki wrote: > virtio-net have two usage of hashes: one is RSS and another is hash > reporting. Conventionally the hash calculation was done by the VMM. > However, computing the hash after the queue was chosen defeats the > purpose of RSS. > > Another approach is to use eBPF steering program. This approach has > another downside: it cannot report the calculated hash due to the > restrictive nature of eBPF. > > Introduce the code to compute hashes to the kernel in order to overcome > thse challenges. > > An alternative solution is to extend the eBPF steering program so that it > will be able to report to the userspace, but it is based on context > rewrites, which is in feature freeze. We can adopt kfuncs, but they will > not be UAPIs. We opt to ioctl to align with other relevant UAPIs (KVM > and vhost_net). This will be useful for DPDK. But there still are cases where custom flow rules are needed. I.e the RSS happens after other TC rules. It would be a good if skbedit supported RSS as an option.