From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Breno Leitao <leitao@debian.org>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
thepacketgeek@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, davej@codemonkey.org.uk,
vlad.wing@gmail.com, max@kutsevol.com
Subject: Re: [PATCH net-next v3 03/10] net: netconsole: separate fragmented message handling in send_ext_msg
Date: Sun, 15 Sep 2024 19:19:10 +0100 [thread overview]
Message-ID: <20240915181910.GB167971@kernel.org> (raw)
In-Reply-To: <20240915165806.2f6e36a8@kernel.org>
On Sun, Sep 15, 2024 at 04:58:06PM +0200, Jakub Kicinski wrote:
> On Tue, 10 Sep 2024 03:03:58 -0700 Breno Leitao wrote:
> > + if (userdata)
> > + userdata_len = nt->userdata_length;
>
> I think this will case a transient build failure with
> CONFIG_NETCONSOLE_DYNAMIC=n. kbuild bot probably didn't
> notice because subsequent patch removes this line,
> but we should avoid potentially breaking bisection.
FWIIW, I confirmed that is the case.
next prev parent reply other threads:[~2024-09-15 18:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 10:03 [PATCH net-next v3 00/10] netconsole refactoring and warning fix Breno Leitao
2024-09-10 10:03 ` [PATCH net-next v3 01/10] net: netconsole: remove msg_ready variable Breno Leitao
2024-09-10 10:03 ` [PATCH net-next v3 02/10] net: netconsole: split send_ext_msg_udp() function Breno Leitao
2024-09-10 10:03 ` [PATCH net-next v3 03/10] net: netconsole: separate fragmented message handling in send_ext_msg Breno Leitao
2024-09-15 14:58 ` Jakub Kicinski
2024-09-15 18:19 ` Simon Horman [this message]
2024-09-16 8:49 ` Breno Leitao
2024-09-10 10:03 ` [PATCH net-next v3 04/10] net: netconsole: rename body to msg_body Breno Leitao
2024-09-10 10:04 ` [PATCH net-next v3 05/10] net: netconsole: introduce variable to track body length Breno Leitao
2024-09-10 10:04 ` [PATCH net-next v3 06/10] net: netconsole: track explicitly if msgbody was written to buffer Breno Leitao
2024-09-15 15:00 ` Jakub Kicinski
2024-09-10 10:04 ` [PATCH net-next v3 07/10] net: netconsole: extract release appending into separate function Breno Leitao
2024-09-10 10:04 ` [PATCH net-next v3 08/10] net: netconsole: do not pass userdata up to the tail Breno Leitao
2024-09-10 15:39 ` Simon Horman
2024-09-10 10:04 ` [PATCH net-next v3 09/10] net: netconsole: split send_msg_fragmented Breno Leitao
2024-09-10 10:04 ` [PATCH net-next v3 10/10] net: netconsole: fix wrong warning Breno Leitao
2024-09-10 14:50 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240915181910.GB167971@kernel.org \
--to=horms@kernel.org \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@kutsevol.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thepacketgeek@gmail.com \
--cc=vlad.wing@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).