From: Simon Horman <horms@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Felix Huettner <felix.huettner@mail.schwarz>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Jozsef Kadlecsik <kadlec@netfilter.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH net v1 1/1] netfilter: conntrack: Guard possoble unused functions
Date: Mon, 16 Sep 2024 16:17:09 +0100 [thread overview]
Message-ID: <20240916151709.GA396300@kernel.org> (raw)
In-Reply-To: <20240910094520.GB572255@kernel.org>
On Tue, Sep 10, 2024 at 10:45:20AM +0100, Simon Horman wrote:
> On Tue, Sep 10, 2024 at 11:12:21AM +0300, Andy Shevchenko wrote:
> > On Mon, Sep 09, 2024 at 07:30:43PM +0100, Simon Horman wrote:
> > > On Mon, Sep 09, 2024 at 06:36:07PM +0300, Andy Shevchenko wrote:
> > > > On Mon, Sep 09, 2024 at 04:17:12PM +0100, Simon Horman wrote:
> > > > > On Mon, Sep 09, 2024 at 12:37:51PM +0300, Andy Shevchenko wrote:
> > > > > > On Fri, Sep 06, 2024 at 05:29:38PM +0100, Simon Horman wrote:
> > > > > > > On Thu, Sep 05, 2024 at 11:36:12PM +0300, Andy Shevchenko wrote:
> > > > > >
> > > > > > > Local testing seems to show that the warning is still emitted
> > > > > > > for ctnetlink_label_size if CONFIG_NETFILTER_NETLINK_GLUE_CT is enabled
> > > >
> > > > Hold on, this is not related to the patch.
> > > > It might be another issue.
> > >
> > > Yes, sorry, I see that now too.
> > >
> > > Perhaps it can be fixed separately, something like this:
> >
> > If you make a patch, it will help somebody who has that in their configuration
> > files enabled (with the other one being disabled). Note, I use x86_64_defconfig
> > which doesn't have this specific issue to be occurred.
>
> Thanks, I'll plan to submit a patch.
The patch grew into two, I've posted them here:
- [PATCH nf-next 0/2] netfilter: conntrack: label helpers conditional compilation updates
https://lore.kernel.org/netfilter-devel/20240916-ct-ifdef-v1-0-81ef1798143b@kernel.org/
prev parent reply other threads:[~2024-09-16 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 20:36 [PATCH net v1 1/1] netfilter: conntrack: Guard possoble unused functions Andy Shevchenko
2024-09-06 16:29 ` Simon Horman
2024-09-06 16:31 ` Simon Horman
2024-09-09 9:26 ` Andy Shevchenko
2024-09-09 9:37 ` Andy Shevchenko
2024-09-09 15:17 ` Simon Horman
2024-09-09 15:36 ` Andy Shevchenko
2024-09-09 18:30 ` Simon Horman
2024-09-10 8:12 ` Andy Shevchenko
2024-09-10 9:45 ` Simon Horman
2024-09-16 15:17 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916151709.GA396300@kernel.org \
--to=horms@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=felix.huettner@mail.schwarz \
--cc=justinstitt@google.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).