From: Jakub Kicinski <kuba@kernel.org>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Erni Sri Satya Vennela <ernis@linux.microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
Dexuan Cui <decui@microsoft.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"shradhagupta@linux.microsoft.com"
<shradhagupta@linux.microsoft.com>,
"ahmed.zaki@intel.com" <ahmed.zaki@intel.com>,
"colin.i.king@gmail.com" <colin.i.king@gmail.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: mana: Add get_link and get_link_ksettings in ethtool
Date: Tue, 17 Sep 2024 17:04:06 +0200 [thread overview]
Message-ID: <20240917170406.6a9d6e27@kernel.org> (raw)
In-Reply-To: <PH7PR21MB3260F88970A04FDB9C0ACCC4CA612@PH7PR21MB3260.namprd21.prod.outlook.com>
On Tue, 17 Sep 2024 14:35:21 +0000 Haiyang Zhang wrote:
> > Any reason why? Sometimes people add this callback for virtual
> > devices to expose some approximate speed, but you're not reporting
> > speed, so I'm curious.
> Speed info isn't available from the HW yet. But we are requesting
> that from HW team. For now, we just add some minimal info, like
> duplex, etc.
Unless I'm misreading I don't see the answer to the "why?" in your
reply.
What benefit does reporting duplex on a virtual device bring?
What kind of SW need this current patch?
etc.
next prev parent reply other threads:[~2024-09-17 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 7:44 [PATCH] net: mana: Add get_link and get_link_ksettings in ethtool Erni Sri Satya Vennela
2024-09-14 3:23 ` Jakub Kicinski
2024-09-17 14:35 ` Haiyang Zhang
2024-09-17 15:04 ` Jakub Kicinski [this message]
2024-09-17 20:34 ` Haiyang Zhang
2024-09-19 7:45 ` Jakub Kicinski
2024-09-20 12:49 ` Erni Sri Satya Vennela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240917170406.6a9d6e27@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=ernis@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).