From: Simon Horman <horms@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Igal Liberman <igal.liberman@freescale.com>,
Jakub Kicinski <kuba@kernel.org>,
Madalin Bucur <madalin.bucur@nxp.com>,
Paolo Abeni <pabeni@redhat.com>,
Sean Anderson <sean.anderson@seco.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: fman: Use of_node_put(muram_node) call only once in read_dts_node()
Date: Sun, 22 Sep 2024 17:41:25 +0100 [thread overview]
Message-ID: <20240922164125.GA3426578@kernel.org> (raw)
In-Reply-To: <e7caae09-70fd-431a-9df2-4c3068851a35@web.de>
On Thu, Sep 19, 2024 at 06:15:23PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 19 Sep 2024 18:05:28 +0200
>
> A of_node_put(muram_node) call was immediately used after a return code
> check for a of_address_to_resource() call in this function implementation.
> Thus use such a function call only once instead directly before the check.
>
> This issue was transformed by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Hi Markus,
I agree with Jacob Keller's comment elsewhere that this seems
to be a reasonable change.
However, I am assuming this is targeted at net-next.
And net-next is currently closed for the v6.12 merge window.
Please consider reposting this patch once net-next reopens.
That will occur after v6.12-rc1 has been released. Which
I expect to be about a week from now.
Also, for networking patches please tag non-bug fixes for
net-next (and bug fixes for net, being sure to include a Fixes tag).
Subject: [PATCH net-next] ...
Please see https://docs.kernel.org/process/maintainer-netdev.html
--
pw-bot: defer
prev parent reply other threads:[~2024-09-22 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 16:15 [PATCH] net: fman: Use of_node_put(muram_node) call only once in read_dts_node() Markus Elfring
2024-09-19 23:07 ` Jacob Keller
2024-09-22 16:41 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240922164125.GA3426578@kernel.org \
--to=horms@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=igal.liberman@freescale.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.anderson@seco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).