Re: [PATCH] Staging: net: nic: Add error pointer check in otx2_flows.c

[kernel test robot <lkp@intel.com>]

Hi Dipendra,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Dipendra-Khadka/Staging-net-nic-Add-error-pointer-check-in-otx2_flows-c/20240923-025325
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20240922185235.50413-1-kdipendra88%40gmail.com
patch subject: [PATCH] Staging: net: nic: Add error pointer check in otx2_flows.c
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240923/202409230844.gM9kqV79-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240923/202409230844.gM9kqV79-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409230844.gM9kqV79-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c: In function 'otx2_alloc_mcam_entries':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c:124:39: error: 'bfvf' undeclared (first use in this function); did you mean 'pfvf'?
     124 |                         mutex_unlock(&bfvf->mbox.lock);
         |                                       ^~~~
         |                                       pfvf
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c:124:39: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c: In function 'otx2_mcam_entry_init':
   drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c:207:31: error: 'bfvf' undeclared (first use in this function); did you mean 'pfvf'?
     207 |                 mutex_unlock(&bfvf->mbox.lock);
         |                               ^~~~
         |                               pfvf


vim +124 drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c

    71	
    72	int otx2_alloc_mcam_entries(struct otx2_nic *pfvf, u16 count)
    73	{
    74		struct otx2_flow_config *flow_cfg = pfvf->flow_cfg;
    75		struct npc_mcam_alloc_entry_req *req;
    76		struct npc_mcam_alloc_entry_rsp *rsp;
    77		int ent, allocated = 0;
    78	
    79		/* Free current ones and allocate new ones with requested count */
    80		otx2_free_ntuple_mcam_entries(pfvf);
    81	
    82		if (!count)
    83			return 0;
    84	
    85		flow_cfg->flow_ent = devm_kmalloc_array(pfvf->dev, count,
    86							sizeof(u16), GFP_KERNEL);
    87		if (!flow_cfg->flow_ent) {
    88			netdev_err(pfvf->netdev,
    89				   "%s: Unable to allocate memory for flow entries\n",
    90				    __func__);
    91			return -ENOMEM;
    92		}
    93	
    94		mutex_lock(&pfvf->mbox.lock);
    95	
    96		/* In a single request a max of NPC_MAX_NONCONTIG_ENTRIES MCAM entries
    97		 * can only be allocated.
    98		 */
    99		while (allocated < count) {
   100			req = otx2_mbox_alloc_msg_npc_mcam_alloc_entry(&pfvf->mbox);
   101			if (!req)
   102				goto exit;
   103	
   104			req->contig = false;
   105			req->count = (count - allocated) > NPC_MAX_NONCONTIG_ENTRIES ?
   106					NPC_MAX_NONCONTIG_ENTRIES : count - allocated;
   107	
   108			/* Allocate higher priority entries for PFs, so that VF's entries
   109			 * will be on top of PF.
   110			 */
   111			if (!is_otx2_vf(pfvf->pcifunc)) {
   112				req->priority = NPC_MCAM_HIGHER_PRIO;
   113				req->ref_entry = flow_cfg->def_ent[0];
   114			}
   115	
   116			/* Send message to AF */
   117			if (otx2_sync_mbox_msg(&pfvf->mbox))
   118				goto exit;
   119	
   120			rsp = (struct npc_mcam_alloc_entry_rsp *)otx2_mbox_get_rsp
   121				(&pfvf->mbox.mbox, 0, &req->hdr);
   122	
   123			if (IS_ERR(rsp)) {
 > 124				mutex_unlock(&bfvf->mbox.lock);
   125				return PTR_ERR(rsp);
   126			}
   127	
   128			for (ent = 0; ent < rsp->count; ent++)
   129				flow_cfg->flow_ent[ent + allocated] = rsp->entry_list[ent];
   130	
   131			allocated += rsp->count;
   132	
   133			/* If this request is not fulfilled, no need to send
   134			 * further requests.
   135			 */
   136			if (rsp->count != req->count)
   137				break;
   138		}
   139	
   140		/* Multiple MCAM entry alloc requests could result in non-sequential
   141		 * MCAM entries in the flow_ent[] array. Sort them in an ascending order,
   142		 * otherwise user installed ntuple filter index and MCAM entry index will
   143		 * not be in sync.
   144		 */
   145		if (allocated)
   146			sort(&flow_cfg->flow_ent[0], allocated,
   147			     sizeof(flow_cfg->flow_ent[0]), mcam_entry_cmp, NULL);
   148	
   149	exit:
   150		mutex_unlock(&pfvf->mbox.lock);
   151	
   152		flow_cfg->max_flows = allocated;
   153	
   154		if (allocated) {
   155			pfvf->flags |= OTX2_FLAG_MCAM_ENTRIES_ALLOC;
   156			pfvf->flags |= OTX2_FLAG_NTUPLE_SUPPORT;
   157		}
   158	
   159		if (allocated != count)
   160			netdev_info(pfvf->netdev,
   161				    "Unable to allocate %d MCAM entries, got only %d\n",
   162				    count, allocated);
   163		return allocated;
   164	}
   165	EXPORT_SYMBOL(otx2_alloc_mcam_entries);
   166	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki