From: Simon Horman <horms@kernel.org>
To: Shen Lichuan <shenlichuan@vivo.com>
Cc: isdn@linux-pingi.de, quic_jjohnson@quicinc.com, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v1] isdn: mISDN: Correct typos in multiple comments across various files
Date: Tue, 24 Sep 2024 13:31:44 +0100 [thread overview]
Message-ID: <20240924123144.GH4029621@kernel.org> (raw)
In-Reply-To: <20240924091117.8137-1-shenlichuan@vivo.com>
On Tue, Sep 24, 2024 at 05:11:17PM +0800, Shen Lichuan wrote:
> Fixed some confusing spelling errors that were currently identified,
> the details are as follows:
>
> -in the code comments:
> netjet.c: 382: overun ==> overrun
> w6692.c: 776: reqest ==> request
> dsp_audio.c: 208: tabels ==> tables
> dsp_cmx.c: 575: suppoted ==> supported
> hwchannel.c: 369: imediately ==> immediately
>
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
> ---
> drivers/isdn/hardware/mISDN/netjet.c | 2 +-
> drivers/isdn/hardware/mISDN/w6692.c | 2 +-
> drivers/isdn/mISDN/dsp_audio.c | 2 +-
> drivers/isdn/mISDN/dsp_cmx.c | 2 +-
> drivers/isdn/mISDN/hwchannel.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
Hi Shen,
Thanks for your patch.
Running codespell over the files modified by this patch indicates
that the following spelling errors remain, I'd suggest addressing them
too.
drivers/isdn/hardware/mISDN/w6692.c:861: oscilator ==> oscillator
drivers/isdn/mISDN/dsp_audio.c:181: aplitude ==> amplitude, aptitude
drivers/isdn/mISDN/dsp_cmx.c:2: conferrencing ==> conferencing
Or perhaps consider extending spelling fixes to cover all files under
drivers/isdn/mISDN and drivers/isdn/hardware/mISDN. There seem to be a lot,
so if so might consider one patch per sub-directory or something like that
to break things up a bit.
On process:
It is my understanding that patches for drivers/isdn are handled by
the netdev maintainers. That is non-bug fixes go into net-next,
and bug fixes go into net. In this case it is not a but fix, so
the patch should be targeted at net-next, like this.
Subject: [PATCH net-next v2] ...
Currently net-next is closed for the v6.12 merge window.
It should reopen after v6.12-rc1 has been released,
which I expect to take place a little under a week from now.
Other than RFCs, patches shouldn't be posted for net-next while it is
closed. So please repost your patch, or post an updated patch once
it reopens.
You can find out more about the development process for the Networking
subsystem here: https://docs.kernel.org/process/maintainer-netdev.html
...
--
pw-bot: defer
prev parent reply other threads:[~2024-09-24 12:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 9:11 [PATCH v1] isdn: mISDN: Correct typos in multiple comments across various files Shen Lichuan
2024-09-24 12:31 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240924123144.GH4029621@kernel.org \
--to=horms@kernel.org \
--cc=isdn@linux-pingi.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=quic_jjohnson@quicinc.com \
--cc=shenlichuan@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).