From: Simon Horman <horms@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: Make OA_TC6 config symbol invisible
Date: Tue, 24 Sep 2024 14:21:09 +0100 [thread overview]
Message-ID: <20240924132109.GK4029621@kernel.org> (raw)
In-Reply-To: <9ebc58517c35a3afc4b19c3844da74984c561268.1727173168.git.geert+renesas@glider.be>
On Tue, Sep 24, 2024 at 12:20:32PM +0200, Geert Uytterhoeven wrote:
> There is no need to ask the user about enabling OPEN Alliance TC6
> 10BASE-T1x MAC-PHY support, as all drivers that use this library select
> the OA_TC6 symbol. Hence make the symbol invisible, unless when
> compile-testing.
>
> Fixes: aa58bec064ab1622 ("net: ethernet: oa_tc6: implement register write operation")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/net/ethernet/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi Geert,
I'm not really convinced this is a fix rather than an enhancement for
net-next. So my suggestion would be to repost, targeted at net-next, and
without a Fixes tag.
Subject: [PATCH net-next] ...
In that scenario, if you wish to refer to the commit that introduced this
problem, then you can use the following in the commit message instead
of the Fixes tag. Unlike the fixes tag, I believe it can be line-wrapped.
commit aa58bec064a ("net: ethernet: oa_tc6: implement register write operation")
As it happens, net-next is currently closed for the v6.12 merge window. And
non-RFC patches for net-next should be posted after it re-opens. Which is
scheduled for after the release of v6.12-rc1.
Sorry for all the process nits :^)
--
pw-bot: defer
prev parent reply other threads:[~2024-09-24 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 10:20 [PATCH] net: ethernet: Make OA_TC6 config symbol invisible Geert Uytterhoeven
2024-09-24 13:21 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240924132109.GK4029621@kernel.org \
--to=horms@kernel.org \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).